Log traceback only on DEBUG for KPO logs read interruption #22595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Logging the traceback after every disconnect is a little overly scary when this is an expected occurrence for long-running pods, and this can create false alarm for users. Here we reduce noise a bit while allowing users to troubleshoot if desired by changing the log level to debug.
boring-cyborg
bot
added
provider:cncf-kubernetes
2 tasks
potiuk
reviewed
Mar 29, 2022
| self.log.warning( | ||
| 'Failed to read logs for pod %s', | ||
| "Reading of logs was interrupted, likely due to a connection issue. " | ||
| "Will retry momentarily.", |
There was a problem hiding this comment.
Should we at least add the error message - not traceback - here in parenthesis (without it, It feels completely blind guessing).
I think that would strike the right balance
potiuk
approved these changes
Mar 29, 2022
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
okay to merge
kaxil
approved these changes
Mar 29, 2022
46 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logging the traceback after every disconnect is a little overly scary when this is an expected occurrence for long-running pods, and this can create false alarm for users. Here we reduce noise a bit while allowing users to troubleshoot if desired by changing the log level to debug.