Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-1906] Fix multiple pykerberos dependencies. #2865

Closed
wants to merge 1 commit into from
Closed

[AIRFLOW-1906] Fix multiple pykerberos dependencies. #2865

wants to merge 1 commit into from

Conversation

snjypl
Copy link
Contributor

@snjypl snjypl commented Dec 9, 2017

Make sure you have checked all steps below.

JIRA

Description

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"
  • Passes git diff upstream/master -u -- "*.py" | flake8 --diff

@codecov-io
Copy link

codecov-io commented Dec 9, 2017

Codecov Report

Merging #2865 into master will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2865      +/-   ##
==========================================
- Coverage   74.05%   73.96%   -0.09%     
==========================================
  Files         160      160              
  Lines       12139    12139              
==========================================
- Hits         8989     8979      -10     
- Misses       3150     3160      +10
Impacted Files Coverage Δ
airflow/task_runner/bash_task_runner.py 93.33% <0%> (-6.67%) ⬇️
airflow/utils/helpers.py 53.44% <0%> (-2.88%) ⬇️
airflow/jobs.py 79.44% <0%> (-0.45%) ⬇️
airflow/models.py 87.47% <0%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9731ce6...6c33430. Read the comment docs.

@snjypl snjypl changed the title [AIRFLOW-1906] Remove ccs-kerberos from dependency [AIRFLOW-1906] Fix multiple pykerberos dependencies. Dec 10, 2017
@snjypl snjypl closed this Dec 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants