Revert "Fixed test and remove pytest.mark.xfail for test_exc_tb" #28840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…)" This reverts commit e16eca2.
dstandish
approved these changes
Jan 10, 2023
jedcunningham
approved these changes
Jan 10, 2023
kaxil
approved these changes
Jan 10, 2023
|
Right my bad on approving it. |
|
@potiuk Easy enough mistake to make. I wrote that test so I know what I was trying to capture/show. |
|
Yeah. The comment you left was actually perfect. If only I read it when approving of course. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #23650
No no no. That was there for a reason. By making this test pass you are encoding that the wrong behaviour is good.
If you want to get rid of the xfail DO NOT just do this.