Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ssh.rst from private-key check #29412

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Feb 7, 2023

The ssh.rst contains a private key example (legitimately), so the file should be excluded from private key check.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

The ssh.rst contains a private key example (legitimately), so the
file should be excluded from private key check.
@potiuk potiuk merged commit 9602f1d into apache:main Feb 7, 2023
@potiuk potiuk deleted the exclude-ssh-rst-from-pivate-key-check branch February 7, 2023 22:43
@potiuk potiuk added this to the Airflow 2.5.2 milestone Feb 8, 2023
@pierrejeambrun pierrejeambrun added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Mar 6, 2023
pierrejeambrun pushed a commit that referenced this pull request Mar 7, 2023
The ssh.rst contains a private key example (legitimately), so the
file should be excluded from private key check.

(cherry picked from commit 9602f1d)
pierrejeambrun pushed a commit that referenced this pull request Mar 8, 2023
The ssh.rst contains a private key example (legitimately), so the
file should be excluded from private key check.

(cherry picked from commit 9602f1d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dev-tools changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants