-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporarily limit botocore upgrades #31098
Conversation
The latest botocore (1.29.127) breaks the way moto creates SQS queues and we need to limit it temporarily so that it will not fail our tests. Related: getmoto/moto#6286 Related: i#31087
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for the quick fix.
IT's a workaround and more of "let's hope they fix it quickly" |
We are engaged with the botocore team right now and working to get a new release pushed out within a couple hours. But we can still merged this in the interim. |
Thanks! That super cool. BTW. Looks like it's |
@potiuk We are also seeing some issues with the Celery Executor when using SQS (so Celery/Kombu) so we're still working on a rollback for that as well. |
This reverts commit a6be96d. Fixes: apache#31087
The latest botocore (1.29.127) breaks the way moto creates SQS queues and we need to limit it temporarily so that it will not fail our tests.
Related: getmoto/moto#6286
Related: i#31087
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.