Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily limit botocore upgrades #31098

Merged
merged 1 commit into from
May 5, 2023
Merged

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented May 5, 2023

The latest botocore (1.29.127) breaks the way moto creates SQS queues and we need to limit it temporarily so that it will not fail our tests.

Related: getmoto/moto#6286
Related: i#31087


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

The latest botocore (1.29.127) breaks the way moto creates SQS
queues and we need to limit it temporarily so that it will not
fail our tests.

Related: getmoto/moto#6286
Related: i#31087
@potiuk potiuk requested a review from ashb as a code owner May 5, 2023 16:30
Copy link
Member

@pankajastro pankajastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for the quick fix.

@potiuk
Copy link
Member Author

potiuk commented May 5, 2023

LGTM. Thank you for the quick fix.

IT's a workaround and more of "let's hope they fix it quickly"

@potiuk potiuk requested review from o-nikolas and eladkal May 5, 2023 16:34
@o-nikolas
Copy link
Contributor

We are engaged with the botocore team right now and working to get a new release pushed out within a couple hours. But we can still merged this in the interim.

@potiuk potiuk merged commit a6be96d into apache:main May 5, 2023
@potiuk potiuk deleted the limit-botocore branch May 5, 2023 16:40
@potiuk
Copy link
Member Author

potiuk commented May 5, 2023

We are engaged with the botocore team right now and working to get a new release pushed out within a couple hours. But we can still merged this in the interim.

Thanks! That super cool. BTW. Looks like it's moto problem only boto/botocore#2930 . so not as "urgent" - we cn wait until moto will catch-up with the changes implemented in the new boto I guess.

@o-nikolas
Copy link
Contributor

o-nikolas commented May 5, 2023

We are engaged with the botocore team right now and working to get a new release pushed out within a couple hours. But we can still merged this in the interim.

Thanks! That super cool. BTW. Looks like it's moto problem only boto/botocore#2930 . so not as "urgent" - we cn wait until moto will catch-up with the changes implemented in the new boto I guess.

@potiuk We are also seeing some issues with the Celery Executor when using SQS (so Celery/Kombu) so we're still working on a rollback for that as well.

potiuk added a commit to potiuk/airflow that referenced this pull request May 5, 2023
eladkal pushed a commit that referenced this pull request May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants