Add active_deadline_seconds parameter to KubernetesPodOperator
#33379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amoghrajesh
requested review from
jedcunningham and
hussein-awala
as code owners
boring-cyborg
bot
added
area:providers
provider:cncf-kubernetes
Lee-W
approved these changes
Aug 14, 2023
potiuk
approved these changes
Aug 14, 2023
|
Needs conflict resolution and fixes in tests ... |
|
@potiuk I fixed the tests as well as rebased it. Can you take a look when free? |
hussein-awala
approved these changes
Aug 14, 2023
eladkal
changed the title
active_deadline_seconds parameter to KubernetesPodOperator
aritra24
approved these changes
Aug 15, 2023
|
@hussein-awala seems like the commit didn't do the trick here. I pushed a new fix now, might just do the trick now |
|
Nope. Seems like it break our K8S tests. FYI. There is a recipe how to setup the environment for K8S tests locally with breeze including step-by-step explanation and example (and Breeze's k8s is really a wizard-like setup that hand-holds you while setting the environment up). https://github.com/apache/airflow/blob/main/TESTING.rst#kubernetes-tests |
|
🎉 |
|
Silly mistake by me. Thanks Hussein! |
|
Thanks @amoghrajesh |
This was referenced Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on top of #31146 to introduce the
active_deadline_secondsfor airflow KPO launched job pods.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.