-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(providers/azure): remove json.dumps when querying AzureCosmosDBHook #33653
fix(providers/azure): remove json.dumps when querying AzureCosmosDBHook #33653
Conversation
The ignore comments you have to put in suggest something is wrong, but I’m not sure if it’s the code or the Azure lib. |
Where is the best place for me to put such comments? Around all the ignores? |
Maybe it woudl be worthwile to add a comment ("The ignores below is due to typing bug in azure lib x.y.z" . I also usually try to find if there is an issue open for that and if not i open it mysefl and post a link to the issue. This way anyone might check in the future if the issue has been solved and remove those unnecessary ignores when we upgrade. |
3cdbd46
to
62c0bc6
Compare
json.dumps leads to "azure.cosmos.exceptions.CosmosHttpResponseError: (BadRequest) Message: {"Errors":["Invalid query. Specified parameterized query JSON is malformed."]}"
62c0bc6
to
fe2567a
Compare
There was not. But I created one. Just added comments to the ignore |
json.dumps
leads toazure.cosmos.exceptions.CosmosHttpResponseError: (BadRequest) Message: {"Errors":["Invalid query. Specified parameterized query JSON is malformed."]}
https://github.com/Azure/azure-sdk-for-python/blob/main/sdk/cosmos/azure-cosmos/samples/database_management.py#L41C36-L46
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.