-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable using wif for storage transfer #35292
Enable using wif for storage transfer #35292
Conversation
This will make it possible to use workload identity federation between GCP and AWS.
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
is wif stands for Web Identity Federation ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general looks fine, just need to fix tests and Static Checks, it could be done by install pre-commit, enable it and run linters/formatters against your changes.
In additional I think it could be nice to add link to AwsS3Data spec:
https://cloud.google.com/storage-transfer/docs/reference/rest/v1/TransferSpec#AwsS3Data somewhere into the docstring/comment because it take some time to figure out is it allowed values or not for someone like me who do not use this Operator
@mock.patch( | ||
"airflow.providers.google.cloud.operators.cloud_storage_transfer_service.CloudDataTransferServiceHook" | ||
) | ||
def test_job_create_aws_with_role_arn(self, aws_hook, mock_hook): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You've forgot to mock AwsBaseHook, you need to add @mock.patch("airflow.providers.google.cloud.operators.cloud_storage_transfer_service.AwsBaseHook")
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
closes: #35271
This adds the possibility to input
aws_role_arn
forCloudDataTransferServiceS3ToGCSOperator
which can be used for authentication with workload identity federation between GCP and AWS.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.