Create pre-commit script to prevent creating FAB related migrations #35927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincbeck
requested review from
potiuk,
ashb and
jedcunningham
as code owners
|
@potiuk I cc you, this the result of our chat on that topic |
potiuk
approved these changes
Nov 28, 2023
|
NICE |
ephraimbuddy
added
the
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All tables related to user management (
ab_permission,ab_view_menu,ab_role,ab_permission_view,ab_permission_view_role,ab_user,ab_user_role,ab_register_user) are used exclusively by the FAB auth manager. Since in #35926, FAB auth manager is getting moved to providers, we should no longer have migrations related to these tables in core Airflow. If these tables need a migration, we would need to implement a mechanism where providers could vendor-in migrations and then, add these migrations in thefabprovider. Since we are not sure such migrations will be added, I dont think it is necessary to implement the mechanism now.This PR prevent adding any additional migrations related to these fab tables.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.