-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-2563] Fix PigCliHook Python 3 string/bytes use #3594
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3594 +/- ##
==========================================
+ Coverage 76.85% 77.12% +0.26%
==========================================
Files 204 204
Lines 15522 15522
==========================================
+ Hits 11930 11971 +41
+ Misses 3592 3551 -41
Continue to review full report at Codecov.
|
Unit tests added for PigCliHook as well to prevent future issues.
The failing test appears to have been a flake (Travis reports a 10 minute period of no output on an unrelated test; all tests pass on my fork). |
Please link to your fork instead of retriggering every time. |
Sure, sorry about that! |
Just bumping since it's been ~2 weeks |
LGTM +1 |
Unit tests added for PigCliHook as well to prevent future issues. Closes apache#3594 from jakahn/master
Unit tests added for PigCliHook as well to prevent future issues. Closes apache#3594 from jakahn/master
Unit tests added for PigCliHook as well to prevent future issues. Closes #3594 from jakahn/master
Make sure you have checked all steps below.
JIRA
Description
Tests
tests/hooks/test_pig_hook.py
Commits
Documentation
Code Quality
git diff upstream/master -u -- "*.py" | flake8 --diff