Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add a public interface for custom weight_rule implementation (#35210)" #36066

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

hussein-awala
Copy link
Member

This reverts commit 3385113.

To avoid introducing a new security issue, we've decided to merge #36029 in 2.8.0 if it's ready or revert #35210 and wait for 2.9.0 to have the complete implementation.

For more details: #35210 (comment)

Verified

This commit was signed with the committer’s verified signature.
hussein-awala Hussein Awala
…pache#35210)"

This reverts commit 3385113.
@boring-cyborg boring-cyborg bot added area:API Airflow's REST/HTTP API area:Executors-core LocalExecutor & SequentialExecutor area:serialization area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues kind:documentation labels Dec 5, 2023
@hussein-awala hussein-awala marked this pull request as draft December 5, 2023 10:52
@potiuk potiuk added this to the Airflow 2.8.0 milestone Dec 5, 2023
@ephraimbuddy ephraimbuddy marked this pull request as ready for review December 6, 2023 06:47
@ephraimbuddy
Copy link
Contributor

Any objection to merging this now?

@ephraimbuddy
Copy link
Contributor

Any objection to merging this now?

I tried to drop the commit from 2-8-test but there are conflicts. Merging this and cherry-picking to 2-8-test seems a better solution

@hussein-awala
Copy link
Member Author

Any objection to merging this now?

No, I will duplicate the original commit in my second PR, and try to finish it before Monday.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@ephraimbuddy ephraimbuddy merged commit f60d458 into apache:main Dec 6, 2023
@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Dec 6, 2023
ephraimbuddy pushed a commit that referenced this pull request Dec 6, 2023

Verified

This commit was signed with the committer’s verified signature.
ephraimbuddy Ephraim Anierobi
…35210)" (#36066)

This reverts commit 3385113.

(cherry picked from commit f60d458)
hussein-awala added a commit to hussein-awala/airflow that referenced this pull request Dec 6, 2023

Verified

This commit was signed with the committer’s verified signature.
hussein-awala Hussein Awala
…ntation (apache#35210)" (apache#36066)"

This reverts commit f60d458.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:API Airflow's REST/HTTP API area:Executors-core LocalExecutor & SequentialExecutor area:serialization area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) kind:documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants