Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MSSQL support form Airflow core #36514

Merged
merged 4 commits into from
Jan 3, 2024

Conversation

jscheffl
Copy link
Contributor

This is a follow-up and split form original PR #35868 and just removes all MSSQL support from Airflow Core (w/o breeze, migrations).

As discussed and voted in https://lists.apache.org/thread/pgcgmhf6560k8jbsmz8nlyoxosvltph2

It does NOT remove the provider package, so no misunderstanding: Apache Airflow further will "work" with MSSQL and the provider package and features are not touched. All Operators keep in place. Just the metadata support is reduced to sqlite (dev only), Postgres, MySQL.
Note that for this also the build of MSSQL client code is kept inside the Docker as Provider packages rely on this availability.

@jscheffl
Copy link
Contributor Author

jscheffl commented Dec 31, 2023

  • Double check that with the removal of mssql also in CI do we have a whole in the text matrix of Python/DB editions?

@potiuk
Copy link
Member

potiuk commented Jan 1, 2024

🤞

Copy link
Contributor

@Taragolis Taragolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I think we should also remove some hacks or mssql conditions from the alembic migrations scripts, but it could be done as follow up if we think that might bring a bit more pain if we tried to do it in one go.

@jscheffl
Copy link
Contributor Author

jscheffl commented Jan 3, 2024

I think we should also remove some hacks or mssql conditions from the alembic migrations scripts, but it could be done as follow up if we think that might bring a bit more pain if we tried to do it in one go.

@Taragolis I initially cleaned migration scripts in #35868 but in the PR there was a lot of debate about how to further support legacy migrations. So I separated this out. Might be a future PR. Do you have any specific thing in mind? Maybe we can also just clean these "hacks" and leave the rest of the migrations just untouched.

@jscheffl jscheffl merged commit dec78ab into apache:main Jan 3, 2024
74 checks passed
@ephraimbuddy ephraimbuddy added the type:misc/internal Changelog: Misc changes that should appear in change log label Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:CLI area:dev-tools area:Executors-core LocalExecutor & SequentialExecutor area:providers area:Scheduler including HA (high availability) scheduler area:serialization area:webserver Webserver related Issues kind:documentation provider:fab type:misc/internal Changelog: Misc changes that should appear in change log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants