-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove MSSQL support form Airflow core #36514
Remove MSSQL support form Airflow core #36514
Conversation
|
🤞 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
I think we should also remove some hacks or mssql conditions from the alembic
migrations scripts, but it could be done as follow up if we think that might bring a bit more pain if we tried to do it in one go.
@Taragolis I initially cleaned migration scripts in #35868 but in the PR there was a lot of debate about how to further support legacy migrations. So I separated this out. Might be a future PR. Do you have any specific thing in mind? Maybe we can also just clean these "hacks" and leave the rest of the migrations just untouched. |
This is a follow-up and split form original PR #35868 and just removes all MSSQL support from Airflow Core (w/o breeze, migrations).
As discussed and voted in https://lists.apache.org/thread/pgcgmhf6560k8jbsmz8nlyoxosvltph2
It does NOT remove the provider package, so no misunderstanding: Apache Airflow further will "work" with MSSQL and the provider package and features are not touched. All Operators keep in place. Just the metadata support is reduced to sqlite (dev only), Postgres, MySQL.
Note that for this also the build of MSSQL client code is kept inside the Docker as Provider packages rely on this availability.