Bump min version of amazon-provider related dependencies #36660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
force-pushed
the
update-amazon-provider-dependencies
branch
from
7f708ed
to
7a4b779
Compare
vincbeck
approved these changes
Jan 8, 2024
eladkal
approved these changes
Jan 8, 2024
eladkal
reviewed
Jan 8, 2024
potiuk
force-pushed
the
update-amazon-provider-dependencies
branch
from
7a4b779
to
de452ae
Compare
This is a regular bump of Amazon-provider related dependencies. The way how botocore releases are done, they are putting a lot of strain on `pip` to resolve the right set of dependencies, including long backtracking, when there are too man versions available. Therefore, from time to time, we are bumping minimum version of Amazon-related dependencies to limit the impact frequent releases of boto and botocore has. Also it is generally fine to update min version of dependencies for providers because at the very least users can still use previously released providers in case they have problem with those dependencies, also many of the updated dependencies contain fixes and feature we implicitly depend on and bumping them regulary is a good way to make sure all the functionalities of the Amazon provider are working as expected. Another reason for the bump is that as of 1.33 version botocore and boto version stopped being shifted by 3 (previously boto3 1.28 was the version corresponding to botocore 1.31). As of version 1.33 this problem has been solved. See boto/boto3#2702 Watchtower min version is bumped to version 3 (which is 12 months old even if before we opted for much older (more than 2 years old) and again if users want to use older version of watchtower, they can opt for previous provider version. This change saves 5-6 minutes of backtracking when `pip` try to find the right version of dependencies when upgrading to newer version. Extracted from apache#36537
potiuk
force-pushed
the
update-amazon-provider-dependencies
branch
from
de452ae
to
f7a7b43
Compare
o-nikolas
approved these changes
Jan 8, 2024
vincbeck
approved these changes
Jan 8, 2024
ferruzzi
approved these changes
Jan 8, 2024
|
Looks like CI failures, but feel free to merge after those are sorted |
ephraimbuddy
added
the
changelog:skip
ephraimbuddy
pushed a commit
that referenced
this pull request
Jan 11, 2024
This is a regular bump of Amazon-provider related dependencies. The way how botocore releases are done, they are putting a lot of strain on `pip` to resolve the right set of dependencies, including long backtracking, when there are too man versions available. Therefore, from time to time, we are bumping minimum version of Amazon-related dependencies to limit the impact frequent releases of boto and botocore has. Also it is generally fine to update min version of dependencies for providers because at the very least users can still use previously released providers in case they have problem with those dependencies, also many of the updated dependencies contain fixes and feature we implicitly depend on and bumping them regulary is a good way to make sure all the functionalities of the Amazon provider are working as expected. Another reason for the bump is that as of 1.33 version botocore and boto version stopped being shifted by 3 (previously boto3 1.28 was the version corresponding to botocore 1.31). As of version 1.33 this problem has been solved. See boto/boto3#2702 Watchtower min version is bumped to version 3 (which is 12 months old even if before we opted for much older (more than 2 years old) and again if users want to use older version of watchtower, they can opt for previous provider version. This change saves 5-6 minutes of backtracking when `pip` try to find the right version of dependencies when upgrading to newer version. Extracted from #36537 (cherry picked from commit 298c37d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a regular bump of Amazon-provider related dependencies. The way how botocore releases are done, they are putting a lot of strain on
pipto resolve the right set of dependencies, including long backtracking, when there are too man versions available.Therefore, from time to time, we are bumping minimum version of Amazon-related dependencies to limit the impact frequent releases of boto and botocore has. Also it is generally fine to update min version of dependencies for providers because at the very least users can still use previously released providers in case they have problem with those dependencies, also many of the updated dependencies contain fixes and feature we implicitly depend on and bumping them regulary is a good way to make sure all the functionalities of the Amazon provider are working as expected.
Another reason for the bump is that as of 1.33 version botocore and boto version stopped being shifted by 3 (previously boto3 1.28 was the version corresponding to botocore 1.31). As of version 1.33 this problem has been solved. See boto/boto3#2702
Watchtower min version is bumped to version 3 (which is 12 months old even if before we opted for much older (more than 2 years old) and again if users want to use older version of watchtower, they can opt for previous provider version.
This change saves 5-6 minutes of backtracking when
piptry to find the right version of dependencies when upgrading to newer version.Extracted from #36537
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.