Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Cohere min version to limit backtracking on upgrade #36666

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Jan 8, 2024

While testing #36537 I noticed cohere backracking quite a bit with older version. Bumping Cohere to more recent minimum version (released in November) decreased it quite a bit.

Since Cohere is mostly standalone package, and likely you want to bump people to later version, it's safe to assume we can bump the minimum version.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

While testing apache#36537 I noticed cohere backracking quite a bit with
older version. Bumping Cohere to more recent minimum version
(released in November) decreased it quite a bit.

Since Cohere is mostly standalone package, and likely you want to
bump people to later version, it's safe to assume we can bump the
minimum version.
Copy link
Contributor

@utkarsharma2 utkarsharma2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@potiuk potiuk merged commit 9797f92 into apache:main Jan 8, 2024
78 checks passed
@potiuk potiuk deleted the bump-min-cohere-version branch January 8, 2024 19:49
potiuk added a commit that referenced this pull request Jan 13, 2024
While testing #36537 I noticed cohere backracking quite a bit with
older version. Bumping Cohere to more recent minimum version
(released in November) decreased it quite a bit.

Since Cohere is mostly standalone package, and likely you want to
bump people to later version, it's safe to assume we can bump the
minimum version.

(cherry picked from commit 9797f92)
@potiuk potiuk added this to the Airflow 2.8.1 milestone Jan 13, 2024
@potiuk potiuk added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Jan 13, 2024
potiuk added a commit that referenced this pull request Jan 13, 2024
While testing #36537 I noticed cohere backracking quite a bit with
older version. Bumping Cohere to more recent minimum version
(released in November) decreased it quite a bit.

Since Cohere is mostly standalone package, and likely you want to
bump people to later version, it's safe to assume we can bump the
minimum version.

(cherry picked from commit 9797f92)
ephraimbuddy pushed a commit that referenced this pull request Jan 15, 2024
While testing #36537 I noticed cohere backracking quite a bit with
older version. Bumping Cohere to more recent minimum version
(released in November) decreased it quite a bit.

Since Cohere is mostly standalone package, and likely you want to
bump people to later version, it's safe to assume we can bump the
minimum version.

(cherry picked from commit 9797f92)
abhishekbhakat pushed a commit to abhishekbhakat/my_airflow that referenced this pull request Mar 5, 2024
While testing apache#36537 I noticed cohere backracking quite a bit with
older version. Bumping Cohere to more recent minimum version
(released in November) decreased it quite a bit.

Since Cohere is mostly standalone package, and likely you want to
bump people to later version, it's safe to assume we can bump the
minimum version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) provider:cohere
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants