-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check sagemaker training job status before deferring SageMakerTrainingOperator #36685
Merged
phanikumv
merged 12 commits into
apache:main
from
astronomer:check-sagemaker-training-job-status-before-deferring
Feb 5, 2024
Merged
check sagemaker training job status before deferring SageMakerTrainingOperator #36685
phanikumv
merged 12 commits into
apache:main
from
astronomer:check-sagemaker-training-job-status-before-deferring
Feb 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 9, 2024
e7d9b8d
to
97e7d92
Compare
1ed4567
to
d1aabc5
Compare
d1aabc5
to
8914b72
Compare
pankajkoti
reviewed
Jan 19, 2024
8914b72
to
3828cde
Compare
74b8713
to
2d13124
Compare
7471a1a
to
026f528
Compare
pankajkoti
approved these changes
Feb 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a static check is failing
d29d34b
to
358a20f
Compare
…akerTrainingOperator
…illable_seconds staticmethod
…ggerTrainingPrintLogTrigger
…igger as SageMakerTrainingPrintLogTrigger
358a20f
to
9cae465
Compare
phanikumv
approved these changes
Feb 5, 2024
This was referenced Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While running a sagemaker training job in deferrable mode, the condition might already be met before we defer the task into the trigger. This PR intends to check the job status before deferring the task to trigger.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.