Remove usused index on task instance

airflow/migrations/versions/0126_2_7_0_add_index_to_task_instance_table.py

@@ -37,14 +37,12 @@
 
 def upgrade():
     """Apply Add index to task_instance table"""
-    op.create_index(
-        "ti_state_incl_start_date",
-        "task_instance",
-        ["dag_id", "task_id", "state"],
-        postgresql_include=["start_date"],
-    )
+    # We don't add this index anymore because it's not useful.
+    pass
 
 
 def downgrade():
     """Unapply Add index to task_instance table"""
-    op.drop_index("ti_state_incl_start_date", table_name="task_instance")
+    # At 2.9 we removed this index as it is not used, and changed this migration not to add it
+    # So we use drop if exists (cus it might not be there)
+    op.drop_index("ti_state_incl_start_date", table_name="task_instance", if_exists=True)

airflow/models/taskinstance.py

@@ -1259,7 +1259,6 @@ class TaskInstance(Base, LoggingMixin):
         # Existing "ti_state_lkp" is not enough for such query when this table has millions of rows, since
         # rows have to be fetched in order to retrieve the start_date column. With this index, INDEX ONLY SCAN
         # is performed and that query runs within milliseconds.
-        Index("ti_state_incl_start_date", dag_id, task_id, state, postgresql_include=["start_date"]),
         Index("ti_pool", pool, state, priority_weight),
         Index("ti_job_id", job_id),
         Index("ti_trigger_id", trigger_id),

docs/apache-airflow/img/airflow_erd.sha256

@@ -1 +1 @@
-194706fc390025f473f73ce934bfe4b394b50ce76748e5df33ae643e38538357
+ba96d49079fd4b81687cad9fbeb1d3f82a214b9277de46eaed3b60126210f7d8

docs/apache-airflow/migrations-ref.rst

@@ -39,7 +39,9 @@ Here's the list of all the Database Migrations that are executed via when you ru
 +---------------------------------+-------------------+-------------------+--------------------------------------------------------------+
 | Revision ID                     | Revises ID        | Airflow Version   | Description                                                  |
 +=================================+===================+===================+==============================================================+
-| ``10b52ebd31f7`` (head)         | ``bd5dfbe21f88``  | ``2.8.0``         | Add processor_subdir to ImportError.                         |
+| ``88344c1d9134`` (head)         | ``10b52ebd31f7``  | ``2.9.0``         | refactor dag run indexes                                     |
++---------------------------------+-------------------+-------------------+--------------------------------------------------------------+
+| ``10b52ebd31f7``                | ``bd5dfbe21f88``  | ``2.8.0``         | Add processor_subdir to ImportError.                         |
 +---------------------------------+-------------------+-------------------+--------------------------------------------------------------+
 | ``bd5dfbe21f88``                | ``f7bf2a57d0a6``  | ``2.8.0``         | Make connection login/password TEXT                          |
 +---------------------------------+-------------------+-------------------+--------------------------------------------------------------+