-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Qdrant Provider #36805
Add Qdrant Provider #36805
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that some of the hook tests are not needed since there is no wrapper for the client methods in the hook, you call them from the client and you check if they are called. Same for the hook integration tests. I don't have a strong opinion on this, let's wait for the other reviews.
Right. There were some wrapper methods before this commit. But then they seemed redundant as the caller can very well get the client through |
Co-authored-by: Elad Kalif <45845474+eladkal@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
FYI: @Anush008 : You will have to make your provider compatible with Airflow 2.7.0+ the compatibility checks detected, that your provider requires Pydantic 2 by, which is not supported in |
Hey.
|
It's problem with Airflow - 2.6 has problem with Pydantic 2 (that's why you need to limit qdran to >= 2.7.0 because Airflow 2.6.* only supports Pydantic 1). That's why you cannot install qdrant on it. As of 2.7 Airflow supports both Pydantic 1/2 and in 2.8 only Pydantic >=2 |
It's problem with Airflow - 2.6 has problem with Pydantic 1(that's why you need to limit it. That's why you cannot install qdrant on it. As of 2.7 airflwo supports both an d in 2.8. only >2 Or so it looked like(I now am using a phone) |
FINALLY GREEN !!!. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 |
Thanks @potiuk, @eladkal, @josh-fell, @hussein-awala for supporting this 🙏🙏. Do let me know if there's anything else needed. |
Usually the real work starts after it gets in the hands of the users :) |
This PR intends to add Qdrant as a supported provider by implementing an operator and hook that enables interfacing with Qdrant within Airflow DAGs.
Qdrant is an open-source, Apache-licensed, vector search engine and database.
[Discussion] Add Qdrant as a supported provider
[LAZY CONSENSUS] Adding an Airflow provider for Qdrant