Fix GCS Anonymous user issue because none token #38102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:google
utkarsharma2
approved these changes
Mar 14, 2024
tatiana
pushed a commit
to astronomer/astronomer-cosmos
that referenced
this pull request
Nov 19, 2024
During the work on PR #1297, an issue arose where the GCP remote manifest task began failing after installing providers and packages with constraints. To allow other tests, which were running successfully, to proceed, the task was temporarily disabled. Upon reviewing the GitHub Actions logs from previous successful runs, it was [observed](https://github.com/astronomer/astronomer-cosmos/actions/runs/11573670971/job/32216315282#step:6:247) that the Google provider version installed was 10.24.0. However, after the refactoring introduced in the PR, the failing actions showed google-provider==10.12.0 being installed. To investigate, I tested locally to identify a working version. While the task failed with 10.16.0, it succeeded with 10.17.0. Analyzing the failure [logs](https://github.com/astronomer/astronomer-cosmos/actions/runs/11908675905/job/33184572638#step:7:417) and reviewing the Google provider changelog revealed that our CI uses a Google connection without a token, leading to authentication failures. This issue had been addressed in [PR #38102](apache/airflow#38102) and resolved in `apache-airflow-providers-google==10.17.0`. Therefore, I propose using google provider>=10.17.0. However, the Airflow constraints file for version 2.9 specifies google provider==10.16.0, which conflicts with this requirement. To address this, I am making changes to the pre-install script in our CI to install google provider>=10.17.0 without relying on the constraints file, citing the reasons above. Related: #1304
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #37834
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.