Switch to pip for all PROD images built in the release branches
#38749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In main we are using `uv` to build CI and PROD images to gain enormous speed improvements. This helps with faster PR checks and iterations and lowers the CI cost. However `uv` is not entirely stable yet and there are conditions that make it fail sometimes (for example when old packages, not excluded by our limits are published with wrong versions), also release imge is built with `pip` and will continue to be built with `pip`. The gains for PROD iumage builds with uv are much smaller than the ones for CI builds, so it's perfectly fine to switch all `release branch` builds to use `pip` for PROD image builds - we do not loose too much by doing it, but we gain stability.
potiuk
requested review from
pankajkoti,
aritra24,
eladkal,
ephraimbuddy and
jedcunningham
|
Side comment: I love how easy it is now to make changes like that to the CI workflows of ours after I restructured it :) |
jedcunningham
approved these changes
Apr 4, 2024
aritra24
approved these changes
Apr 4, 2024
potiuk
deleted the
switch-to-pip-for-release-branches-in-prod-image-builds
branch
potiuk
added a commit
that referenced
this pull request
Apr 4, 2024
…8749) In main we are using `uv` to build CI and PROD images to gain enormous speed improvements. This helps with faster PR checks and iterations and lowers the CI cost. However `uv` is not entirely stable yet and there are conditions that make it fail sometimes (for example when old packages, not excluded by our limits are published with wrong versions), also release imge is built with `pip` and will continue to be built with `pip`. The gains for PROD iumage builds with uv are much smaller than the ones for CI builds, so it's perfectly fine to switch all `release branch` builds to use `pip` for PROD image builds - we do not loose too much by doing it, but we gain stability. (cherry picked from commit be89300)
potiuk
added
the
changelog:skip
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Apr 4, 2024
A follow up after apache#38749 - we should also disable UV for cache building in release branches. PROD images are building just fine, but cache building for 3.11 fails for the same reason and we also have to disable UV for the cache build.
potiuk
added a commit
that referenced
this pull request
Apr 4, 2024
A follow up after #38749 - we should also disable UV for cache building in release branches. PROD images are building just fine, but cache building for 3.11 fails for the same reason and we also have to disable UV for the cache build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In main we are using
uvto build CI and PROD images to gain enormous speed improvements. This helps with faster PR checks and iterations and lowers the CI cost. Howeveruvis not entirely stable yet and there are conditions that make it fail sometimes (for example when old packages, not excluded by our limits are published with wrong versions), also release imge is built withpipand will continue to be built withpip. The gains for PROD iumage builds with uv are much smaller than the ones for CI builds, so it's perfectly fine to switch allrelease branchbuilds to usepipfor PROD image builds - we do not loose too much by doing it, but we gain stability.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.