-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openlineage, redshift: do not call DB for schemas below Airflow 2.10 #40197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maciej Obuchowski <obuchowski.maciej@gmail.com>
boring-cyborg
bot
added
area:providers
provider:amazon-aws
AWS/Amazon - related issues
provider:openlineage
AIP-53
labels
Jun 12, 2024
Closed
2 tasks
JDarDagran
approved these changes
Jun 12, 2024
Do you think we could add similar condition to revert/change on #39113? |
@JDarDagran yup, however I'd not mix those two up in same PR here 🙂 And would do this followup actually when #40078 gets merged. |
kacpermuda
approved these changes
Jun 12, 2024
pankajastro
approved these changes
Jun 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
potiuk
approved these changes
Jun 14, 2024
96 tasks
20 tasks
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Jul 26, 2024
…pache#40197) Signed-off-by: Maciej Obuchowski <obuchowski.maciej@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #39969.
Similar to #39113 - do not run external queries for Redshift. The difference in this PR is that with 2.10 and above - if we get #40078 merged we can run this and accept that in very small amount of cases Redshift extraction will time out - but won't affect task.