Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openlineage, redshift: do not call DB for schemas below Airflow 2.10 #40197

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

mobuchowski
Copy link
Contributor

@mobuchowski mobuchowski commented Jun 12, 2024

Fix for #39969.
Similar to #39113 - do not run external queries for Redshift. The difference in this PR is that with 2.10 and above - if we get #40078 merged we can run this and accept that in very small amount of cases Redshift extraction will time out - but won't affect task.

Signed-off-by: Maciej Obuchowski <obuchowski.maciej@gmail.com>
@JDarDagran
Copy link
Contributor

Do you think we could add similar condition to revert/change on #39113?

@mobuchowski
Copy link
Contributor Author

@JDarDagran yup, however I'd not mix those two up in same PR here 🙂 And would do this followup actually when #40078 gets merged.

Copy link
Member

@pankajastro pankajastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mobuchowski mobuchowski merged commit 6f40984 into main Jun 14, 2024
50 checks passed
@RNHTTR RNHTTR deleted the redshift-remove-calls branch June 20, 2024 22:21
romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Jul 26, 2024
…pache#40197)

Signed-off-by: Maciej Obuchowski <obuchowski.maciej@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants