Add [webserver]update_fab_perms to deprecated configs

[ephraimbuddy]

[webserver]update_fab_perms is deprecated in favour of [fab]update_fab_perms and has been a breaking change since 2.9.0. This PR adds the config to the deprecated config list to properly inform users and have both options work at the moment

[ashb]

I wonder if we should also maybe the config in the fab provider look at the the old config as well?

It's fairly niche so I don't mind either way if we decide to leave the provider looking only at the new option

[ashb]

An alternative (that I don't think I like, but it is an option) is to mutate configuration.ConfigParser.deprecated_options to add the FAB option from within the FAB provider itself. That feels icky though

[ephraimbuddy]

An alternative (that I don't think I like, but it is an option) is to mutate configuration.ConfigParser.deprecated_options to add the FAB option from within the FAB provider itself. That feels icky though

I moved the provider config loading into AppBuilder init section. Looks like it makes sense that way

[ephraimbuddy]

I had to let the doc builder build FAB configuration to fix the doc configuration issue. I haven't figured a better way to fix it cc @potiuk. The doc issue : https://github.com/apache/airflow/actions/runs/9585199812/job/26430786160?pr=40317#step:7:14376

[potiuk]

The first two errors were causing all the others @ephraimbuddy - apparently somewhere there is a reference to config:fab__auth_rate_limit and this reference is gone when you move configuration to fab provider - it should point to fab provider configuration instead using intersphinx references

------------------------------ Error   2 --------------------
 WARNING: undefined label: 'config:fab__auth_rate_limit'

File path: /opt/airflow/docs/apache-airflow/<unknown>
------------------------------ Error   3 --------------------
 WARNING: undefined label: 'config:fab__update_fab_perms'

[ephraimbuddy]

The first two errors were causing all the others @ephraimbuddy - apparently somewhere there is a reference to config:fab__auth_rate_limit and this reference is gone when you move configuration to fab provider - it should point to fab provider configuration instead using intersphinx references

------------------------------ Error   2 --------------------
 WARNING: undefined label: 'config:fab__auth_rate_limit'

File path: /opt/airflow/docs/apache-airflow/<unknown>
------------------------------ Error   3 --------------------
 WARNING: undefined label: 'config:fab__update_fab_perms'

I can't find the references of those configs. The issue seems to come from having ("fab", "auth_rate_limit"), etc in deprecations while there's no reference to the fab section in core airflow documentation. The docs build fine when the items are removed from the deprecation sections. The provided solution of having the fab section in core config ref also solved this.
cc @potiuk

[potiuk]

I can't find the references of those configs. The issue seems to come from having ("fab", "auth_rate_limit"), etc in

This is the issues-> those deprecations will automatically generate links to the new parameters like for example here:

And this is where it fails, because they cannot be found as they are now generated in fab provider module not in airflow - I think it's worth checking how generated documentation looks like and whether it does not cause duplication for those deprecated parameter descriptions.

[potiuk]

Yes. As I thought. What happens now is that generated documentation is wrong:

Fab parameters are present in "airflow" docs

But also FAB parameters are missing in fab provider docs (also in "production" documentation).

(only auth_rate_limit is present).

After a closer look - it looks like simply version_added is set wrongly in FAB's provider.yaml

And actually fixing versions there should be the only thing needed to fix the problem.

[ephraimbuddy]

Yeah, that solved it. Thanks so much @potiuk

[DartVeDroid]

@ephraimbuddy,
I'm getting FutureWarning: section/key [webserver/update_fab_perms] has been deprecated, you should use[fab/update_fab_perms] instead., despite having already set that in airflow.cfg.
Is that supposed to happen?
Also, why no spacebar after "use"? =D

[ephraimbuddy]

@ephraimbuddy, I'm getting FutureWarning: section/key [webserver/update_fab_perms] has been deprecated, you should use[fab/update_fab_perms] instead., despite having already set that in airflow.cfg. Is that supposed to happen? Also, why no spacebar after "use"? =D

Can you check if you have webserver/update_fab_perms set somewhere? Feel free to contribute a fix for the space issue you discovered