Replace usages of task context logger with the log table #40867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstandish
requested review from
hussein-awala,
eladkal,
o-nikolas,
ryanahamilton,
ashb,
bbovenzi,
pierrejeambrun,
ephraimbuddy,
kaxil and
XD-DENG
as code owners
boring-cyborg
bot
added
area:API
|
Some tests need to be updated though |
vincbeck
reviewed
Jul 18, 2024
The task context logger is inefficient; Log is better for this reason.
Co-authored-by: Vincent <97131062+vincbeck@users.noreply.github.com>
dstandish
force-pushed
the
replace-usages-of-task-context-logger-with-the-log-table
branch
from
167cf37 to
9225fbf
Compare
dstandish
force-pushed
the
replace-usages-of-task-context-logger-with-the-log-table
branch
from
a069dac to
764930e
Compare
dstandish
force-pushed
the
replace-usages-of-task-context-logger-with-the-log-table
branch
2 times, most recently
from
c098177 to
26d5331
Compare
vincbeck
approved these changes
Jul 19, 2024
dstandish
commented
Jul 19, 2024
dstandish
deleted the
replace-usages-of-task-context-logger-with-the-log-table
branch
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Jul 26, 2024
Use Log table instead of task context logger The task context logger is inefficient; Log is better for this reason --------- Co-authored-by: Vincent <97131062+vincbeck@users.noreply.github.com>
This was referenced Jul 28, 2024
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shipping messages to TI logs, which unfortunately in many cases means uploading to s3, is inefficient, and not really something the scheduler should be doing.
Instead we can use an old but underutilized feature: the Log table.
I have to do some trickery to save log events from executors, namely store them in a queue and consume them in the scheduler loop.