Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-3288] Add SNS integration #4123

Merged
merged 1 commit into from
Nov 3, 2018

Conversation

sjednac
Copy link
Contributor

@sjednac sjednac commented Nov 1, 2018

Jira

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Adds a hook and a basic operator for publishing Amazon SNS messages.

Our project is currently using an identical plugin for integrating SQS into our Airflow pipelines, but it could be used for other purposes as well (e-mail, sms, lambda function invocation etc.).

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

The hook and the operator have independent unit tests.

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.

Classes and methods should be documented.

Code Quality

  • Passes flake8

Provides a hook and an operator for publishing Amazon SNS messages.

Useful for integrating various Amazon services (SQS, Lambda) and
sending regular notifications (e-mail, SMS, ...).
@codecov-io
Copy link

codecov-io commented Nov 1, 2018

Codecov Report

Merging #4123 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4123   +/-   ##
=======================================
  Coverage   76.66%   76.66%           
=======================================
  Files         199      199           
  Lines       16209    16209           
=======================================
  Hits        12427    12427           
  Misses       3782     3782

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc3108e...55f839a. Read the comment docs.

@msumit
Copy link
Contributor

msumit commented Nov 3, 2018

lgtm

@msumit msumit merged commit bb22462 into apache:master Nov 3, 2018
@ashb
Copy link
Member

ashb commented Nov 6, 2018

These new classes are not linked from the docs - please add them to at least docs/code.rst

@sjednac
Copy link
Contributor Author

sjednac commented Nov 6, 2018

@ashb

  1. Sorry about that - I'm going to open a PR fixing this shortly.
  2. I'd suggest to include this info in the PR template, as the following is not clear enough in my opinion:

When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added

wyndhblb pushed a commit to asappinc/incubator-airflow that referenced this pull request Nov 9, 2018
Provides a hook and an operator for publishing Amazon SNS messages.

Useful for integrating various Amazon services (SQS, Lambda) and
sending regular notifications (e-mail, SMS, ...).
tmiller-msft pushed a commit to cse-airflow/incubator-airflow that referenced this pull request Nov 27, 2018
Provides a hook and an operator for publishing Amazon SNS messages.

Useful for integrating various Amazon services (SQS, Lambda) and
sending regular notifications (e-mail, SMS, ...).
elizabethhalper pushed a commit to cse-airflow/incubator-airflow that referenced this pull request Dec 7, 2018
Provides a hook and an operator for publishing Amazon SNS messages.

Useful for integrating various Amazon services (SQS, Lambda) and
sending regular notifications (e-mail, SMS, ...).
aliceabe pushed a commit to aliceabe/incubator-airflow that referenced this pull request Jan 3, 2019
Provides a hook and an operator for publishing Amazon SNS messages.

Useful for integrating various Amazon services (SQS, Lambda) and
sending regular notifications (e-mail, SMS, ...).
ashb pushed a commit that referenced this pull request Mar 26, 2019
Provides a hook and an operator for publishing Amazon SNS messages.

Useful for integrating various Amazon services (SQS, Lambda) and
sending regular notifications (e-mail, SMS, ...).
wmorris75 pushed a commit to modmed/incubator-airflow that referenced this pull request Jul 29, 2019
Provides a hook and an operator for publishing Amazon SNS messages.

Useful for integrating various Amazon services (SQS, Lambda) and
sending regular notifications (e-mail, SMS, ...).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants