Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Hook Level Lineage support for GCSHook #42507

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

kacpermuda
Copy link
Contributor

@kacpermuda kacpermuda commented Sep 26, 2024

Adding hook level lineage support for GCS Hook. Similar PR for S3 Hook: #40819

Also, Google provider needed some adjustments after Dataset has been renamed to Asset so I've done that as well.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Sep 26, 2024
@kacpermuda kacpermuda force-pushed the hook-level-lineage-add-gcs branch from 4e70d6a to 827c8cf Compare September 26, 2024 15:41
@shahar1
Copy link
Contributor

shahar1 commented Sep 27, 2024

Static checks and LowestDeps tests currently fail

@kacpermuda
Copy link
Contributor Author

Yes, I'm working on fix and also adding tests to my changes. I'll switch to draft before i push it.

@kacpermuda kacpermuda marked this pull request as draft September 27, 2024 10:42
@kacpermuda kacpermuda force-pushed the hook-level-lineage-add-gcs branch from 827c8cf to c0e0e55 Compare September 27, 2024 16:46
@kacpermuda kacpermuda marked this pull request as ready for review September 27, 2024 17:03
Copy link
Contributor

@shahar1 shahar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ensure that your PR complies with the adjustments that were introduced in #41348

@kacpermuda kacpermuda force-pushed the hook-level-lineage-add-gcs branch 3 times, most recently from 876c371 to 74ca8c6 Compare October 22, 2024 14:10
Signed-off-by: Kacper Muda <mudakacper@gmail.com>
@kacpermuda kacpermuda force-pushed the hook-level-lineage-add-gcs branch from 74ca8c6 to 15d3a71 Compare October 22, 2024 18:21
@kacpermuda
Copy link
Contributor Author

@shahar1 It should work well now, adjusted the GCSHook and the whole provider to work with Asset naming instead of Dataset.

Copy link
Contributor

@shahar1 shahar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you :)

@shahar1 shahar1 merged commit cc76229 into apache:main Oct 23, 2024
108 checks passed
harjeevanmaan pushed a commit to harjeevanmaan/airflow that referenced this pull request Oct 23, 2024
Signed-off-by: Kacper Muda <mudakacper@gmail.com>
PaulKobow7536 pushed a commit to PaulKobow7536/airflow that referenced this pull request Oct 24, 2024
Signed-off-by: Kacper Muda <mudakacper@gmail.com>
@kacpermuda kacpermuda deleted the hook-level-lineage-add-gcs branch October 24, 2024 08:43
ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024
Signed-off-by: Kacper Muda <mudakacper@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants