-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Hook Level Lineage support for GCSHook #42507
Conversation
4e70d6a
to
827c8cf
Compare
Static checks and |
Yes, I'm working on fix and also adding tests to my changes. I'll switch to draft before i push it. |
827c8cf
to
c0e0e55
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please ensure that your PR complies with the adjustments that were introduced in #41348
876c371
to
74ca8c6
Compare
Signed-off-by: Kacper Muda <mudakacper@gmail.com>
74ca8c6
to
15d3a71
Compare
@shahar1 It should work well now, adjusted the GCSHook and the whole provider to work with Asset naming instead of Dataset. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thank you :)
Signed-off-by: Kacper Muda <mudakacper@gmail.com>
Signed-off-by: Kacper Muda <mudakacper@gmail.com>
Signed-off-by: Kacper Muda <mudakacper@gmail.com>
Adding hook level lineage support for GCS Hook. Similar PR for S3 Hook: #40819
Also, Google provider needed some adjustments after Dataset has been renamed to Asset so I've done that as well.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.