get_task_instance_try_details API returns TaskInstanceHistory schema

[kandharvishnu]

these API requests

• get_task_instance_try_details
• get_mapped_task_instance_try_details
• get_task_instance_tries
• get_mapped_task_instance_tries

are actually returning TaskInstanceHistory

---

Airflow API Docs mentions that the get_task_instance_try_details return task_instance schema

But API actually returns TaskInstanceHistory schema

get_task_instance_try_details method also returns the TaskInstanceHistory

[pierrejeambrun]

Beside the small comment, looking good.

Maybe @ephraimbuddy can double check ?

[ephraimbuddy]

There's no difference between TI and TI History except for loading related objects. It makes me wonder if we need this PR

[pierrejeambrun]

There's no difference between TI and TI History except for loading related objects. It makes me wonder if we need this PR

In that case exposing a TaskInstance might be sufficient and less confusing for users of the API. Otherwise they might be intrigued by TaskInstanceHistory. Maybe in this PR we can just add a comment in the code, in the TaskInstanceHistory Schema to specify that there are no differences beside loading objects, and that in terms of response TaskInstance is fine ? (All that will be deleted soon anyway).

Also there is the deprecated execution_date difference, maybe the TaskInstanceHistory is missing the logical_date/execution_date ?

[kandharvishnu]

Also there is the deprecated execution_date difference, maybe the TaskInstanceHistory is missing the logical_date/execution_date ?

Additionally, I noticed that the following columns are missing in TaskInstanceHistory when compared with TaskInstance:

• sla_miss
• rendered_map_index
• rendered_fields
• trigger
• triggerer_job
• note

[ephraimbuddy]

Also there is the deprecated execution_date difference, maybe the TaskInstanceHistory is missing the logical_date/execution_date ?

the logical_date/execution_date is a proxy in TaskInstance so we couldn't have it in TI history.

[ephraimbuddy]

Also there is the deprecated execution_date difference, maybe the TaskInstanceHistory is missing the logical_date/execution_date ?

Additionally, I noticed that the following columns are missing in TaskInstanceHistory when compared with TaskInstance:

• sla_miss
• rendered_map_index
• rendered_fields
• trigger
• triggerer_job
• note

Those are the differences. We can't be able to have those in TI history.

[pierrejeambrun]

Those are the differences. We can't be able to have those in TI history.

As there are some differences I think we need to actually fix the spec with the actual response returned. Otherwise client might expect one of those fields trigger, etc.. while those are missing.

[pierrejeambrun]

I recommend to wait for @ephraimbuddy second opinion before merging that. But looks good to me.