Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Python 3.9 as target version for Ruff & Black rules #44298

Merged
merged 2 commits into from
Nov 24, 2024

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Nov 23, 2024

Since we dropped support of Python 3.8 (after it reach EOL), we missed changing rules for black & ruff.

For reviewers: easier to just review first commit, second commit is mostly autogen code


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:API Airflow's REST/HTTP API area:CLI area:dev-tools area:Scheduler including HA (high availability) scheduler area:Triggerer labels Nov 23, 2024
@kaxil kaxil added legacy ui Whether legacy UI change should be allowed in PR legacy api Whether legacy API changes should be allowed in PR labels Nov 23, 2024
@kaxil kaxil force-pushed the bump-checks-to-py39 branch from eafce90 to 83f26a2 Compare November 23, 2024 03:34
Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. How can it be that I over-looked the changes in the first commit when removing Python 3.9 support?

@kaxil kaxil force-pushed the bump-checks-to-py39 branch 2 times, most recently from a9100f8 to bb118b6 Compare November 23, 2024 14:57
@potiuk
Copy link
Member

potiuk commented Nov 24, 2024

Nice - but seems there are still some troubles with collection changes.

BTW. I would like - before merge and when green re-run it locally and reapply ruff auto-changes - to see if I come up with small set of reviewable changes (aka - reproducibility check :)

Since we dropped support of Python 3.8 (after it reach EOL), we missed changing rules for black & ruff.
@kaxil kaxil force-pushed the bump-checks-to-py39 branch from bb118b6 to 254359c Compare November 24, 2024 03:14
@kaxil
Copy link
Member Author

kaxil commented Nov 24, 2024

Nice - but seems there are still some troubles with collection changes.

BTW. I would like - before merge and when green re-run it locally and reapply ruff auto-changes - to see if I come up with small set of reviewable changes (aka - reproducibility check :)

Done, rebased, ran ruff, force pushed locally

@kaxil kaxil merged commit 1275fec into apache:main Nov 24, 2024
132 of 134 checks passed
@kaxil kaxil deleted the bump-checks-to-py39 branch November 24, 2024 04:51
@kaxil
Copy link
Member Author

kaxil commented Nov 24, 2024

Interesting. How can it be that I over-looked the changes in the first commit when removing Python 3.9 support?

You already had to many changes to handle :)

@potiuk
Copy link
Member

potiuk commented Nov 24, 2024

And one more here @jscheffl ;) #44328

@kaxil
Copy link
Member Author

kaxil commented Nov 24, 2024

And one more here @jscheffl ;) #44328

:D

@kaxil
Copy link
Member Author

kaxil commented Nov 24, 2024

Interesting. How can it be that I over-looked the changes in the first commit when removing Python 3.9 support?

All good man

@jscheffl
Copy link
Contributor

And one more here @jscheffl ;) #44328

Hope this was the last one... or shall I go hunting again? :-D

@kaxil
Copy link
Member Author

kaxil commented Nov 24, 2024

And one more here @jscheffl ;) #44328

Hope this was the last one... or shall I go hunting again? :-D

If you wouldn't be missing such things, I would consider you a bot 😄

LefterisXefteris pushed a commit to LefterisXefteris/airflow that referenced this pull request Jan 5, 2025
got686-yandex pushed a commit to got686-yandex/airflow that referenced this pull request Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:API Airflow's REST/HTTP API area:CLI area:dev-tools area:Scheduler including HA (high availability) scheduler area:Triggerer legacy api Whether legacy API changes should be allowed in PR legacy ui Whether legacy UI change should be allowed in PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants