-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dont add extra deps for providers with same cross provider deps #44341
base: main
Are you sure you want to change the base?
Conversation
@potiuk @eladkal @gopidesupavan can you take a look when you have some time? |
@potiuk @gopidesupavan i handled it using the requirements parser, its much cleaner now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool :)
Interesting error. The "get_install_requiresments" is probably not the best idea to use because it adds escaping to
Instead you should just use (and we do not need to us version suffix - this one is merely used to filter out extras - so version suffix does not matter). |
Maybe worth to add a comment in |
Oh i see, let me correct that! |
@potiuk the tests expect a version suffix, do we need it or not at all? |
@potiuk i removed the |
closes: #44195
After changes:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.