Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grid sort bug #46182

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Fix grid sort bug #46182

merged 1 commit into from
Jan 28, 2025

Conversation

bbovenzi
Copy link
Contributor

Fix an issue where the grid view was resorting itself. This was due to the inline use of .reverse() which edited the runs in place. Now we reverse the list using a much safer css approach.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Jan 28, 2025
@bbovenzi
Copy link
Contributor Author

@jscheffl Let me know if this fixes it for you

Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, thanks.

Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, now it is not re-sorting anymore! Thanks!

@jscheffl jscheffl merged commit 336089c into apache:main Jan 28, 2025
36 checks passed
@bbovenzi bbovenzi deleted the fix-grid-view-sort branch January 28, 2025 21:13
got686-yandex pushed a commit to got686-yandex/airflow that referenced this pull request Jan 30, 2025
ambika-garg pushed a commit to ambika-garg/airflow that referenced this pull request Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants