Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-6063] Remove astroid dependency #6659

Merged

Conversation

feluelle
Copy link
Member

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-6063
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

The issue pylint-dev/pylint#3123 has been fixed. So we can remove this dependency from our setup.py.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Note this dependency was only meant to temporarily fix an issue with pylint and astroid.
See pylint-dev/pylint#3123 for more information.
@codecov-io
Copy link

codecov-io commented Nov 25, 2019

Codecov Report

Merging #6659 into master will decrease coverage by 0.25%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6659      +/-   ##
=========================================
- Coverage   83.76%   83.5%   -0.26%     
=========================================
  Files         672     672              
  Lines       37584   37585       +1     
=========================================
- Hits        31482   31387      -95     
- Misses       6102    6198      +96
Impacted Files Coverage Δ
airflow/operators/mysql_operator.py 100% <0%> (ø) ⬆️
airflow/operators/mysql_to_hive.py 100% <0%> (ø) ⬆️
airflow/kubernetes/volume_mount.py 44.44% <0%> (-55.56%) ⬇️
airflow/kubernetes/volume.py 52.94% <0%> (-47.06%) ⬇️
airflow/kubernetes/pod_launcher.py 45.25% <0%> (-46.72%) ⬇️
airflow/kubernetes/refresh_config.py 50.98% <0%> (-23.53%) ⬇️
...rflow/contrib/operators/kubernetes_pod_operator.py 78.2% <0%> (-20.52%) ⬇️
airflow/utils/sqlalchemy.py 93.22% <0%> (+1.69%) ⬆️
airflow/configuration.py 89.13% <0%> (-3.63%) ⬇️
airflow/hooks/hive_hooks.py 77.6% <0%> (ø) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df35957...57c2ef9. Read the comment docs.

@@ -277,7 +277,6 @@ def write_version(filename: str = os.path.join(*["airflow", "git_version"])):
# DEPENDENCIES_EPOCH_NUMBER in the Dockerfile
############################################################################################################
devel = [
'astroid~=2.2.5', # to be removed after pylint solves this: https://github.com/PyCQA/pylint/issues/3123
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can also remove the pylint limit below (same reason) and then we can finally disable module-level docstrings :)

Copy link
Member Author

@feluelle feluelle Nov 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to create a separate PR for that due to a huge amount of changes when upgrading pylint to >= 2.4

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK then :).

@potiuk potiuk merged commit e51e1c7 into apache:master Nov 26, 2019
@feluelle feluelle deleted the feature/AIRFLOW-6063-remove-astroid-dependency branch April 30, 2020 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants