-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-6063] Remove astroid dependency #6659
[AIRFLOW-6063] Remove astroid dependency #6659
Conversation
Note this dependency was only meant to temporarily fix an issue with pylint and astroid. See pylint-dev/pylint#3123 for more information.
Codecov Report
@@ Coverage Diff @@
## master #6659 +/- ##
=========================================
- Coverage 83.76% 83.5% -0.26%
=========================================
Files 672 672
Lines 37584 37585 +1
=========================================
- Hits 31482 31387 -95
- Misses 6102 6198 +96
Continue to review full report at Codecov.
|
@@ -277,7 +277,6 @@ def write_version(filename: str = os.path.join(*["airflow", "git_version"])): | |||
# DEPENDENCIES_EPOCH_NUMBER in the Dockerfile | |||
############################################################################################################ | |||
devel = [ | |||
'astroid~=2.2.5', # to be removed after pylint solves this: https://github.com/PyCQA/pylint/issues/3123 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can also remove the pylint limit below (same reason) and then we can finally disable module-level docstrings :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to create a separate PR for that due to a huge amount of changes when upgrading pylint to >= 2.4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK then :).
Make sure you have checked all steps below.
Jira
Description
The issue pylint-dev/pylint#3123 has been fixed. So we can remove this dependency from our setup.py.
Tests
Commits
Documentation