-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-5843] Add conf option to Add DAG Run view #7281
Conversation
This has no tests, and there should also be a check to ensure that the |
@ashb is there a preferred way to validate the JSON or should I just add a try except with something like "Conf JSON isn't valid"? |
@JCoder01 Yeah a try/except is probably good enough. |
75aca35
to
8d9ab11
Compare
@ashb Ok, can you have a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the exception message this looks good.
Codecov Report
@@ Coverage Diff @@
## master #7281 +/- ##
=========================================
Coverage ? 32.33%
=========================================
Files ? 863
Lines ? 40458
Branches ? 0
=========================================
Hits ? 13083
Misses ? 27375
Partials ? 0
Continue to review full report at Codecov.
|
8d9ab11
to
c14fa13
Compare
Good work @JCoder01 |
Issue link: AIRFLOW-5843
Adds input field to allow passing of conf when adding a dag run in the UI.
Make sure to mark the boxes below before creating PR: [x]
[AIRFLOW-NNNN]
. AIRFLOW-NNNN = JIRA ID** For document-only changes commit message can start with
[AIRFLOW-XXXX]
.In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.