Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding option in run to accept s3_conn_id #843

Closed
wants to merge 1 commit into from

Conversation

msumit
Copy link
Contributor

@msumit msumit commented Jan 7, 2016

Targeting 2 things in this PR:

  1. Ability to specify a s3_conn_id from cli
    airflow run -s3 s3_default example_python_operator print_the_context 2016-01-07
  2. Using calling format in boto, so it doesn't throw ssl exceptions for buckets which have dots in their name.

@jlowin
Copy link
Member

jlowin commented Mar 26, 2016

@msumit I believe this is superseded by #1137 which lets users specify the hook that should be used for remote logging (for example, a specific S3 hook). That should take care of your first issue. If the second issue is still a problem, could you please add a PR to S3Hook directly?

@jlowin jlowin closed this Mar 26, 2016
@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling 24841ed on msumit:s3_conn into 71f99f8 on airbnb:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants