Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: fix time format in de-DE #586

Closed
wants to merge 2 commits into from
Closed

bugfix: fix time format in de-DE #586

wants to merge 2 commits into from

Conversation

xialeistudio
Copy link
Contributor

@xialeistudio xialeistudio commented Oct 26, 2023 •
edited
Loading

Bugfix: fix time format in de-DE

@fenbox fenbox requested a review from shuashuai October 27, 2023 09:01
@shuashuai
Copy link
Member

Fixed this issue #391

I have carefully checked the issu #391. This issue describes not only a time issue, but an issue with the entire language file. Therefore, I will not merge your PR for the time being. If you have the ability to translate the entire de language, you are welcome. Come to crowdin to help us translate and finally complete this PR. Thanks!

shuashuai
shuashuai requested changes Nov 1, 2023
View reviewed changes
Copy link
Member

@shuashuai shuashuai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The modification is incomplete, you can refer to the comments to supplement it.

@shuashuai
Copy link
Member

Fixed this issue #391

Hi, if you just want to fix the timing problem mentioned in this issu, you can close the isu first, re-initiate the PR, and modify the title and commit information of the response, so that your PR is a complete function and we can merge it. Looking forward to your contribution.

@xialeistudio xialeistudio reopened this Nov 14, 2023
@xialeistudio xialeistudio changed the title bugfix: fix #391 bugfix: fix time format in **de-DE** Nov 14, 2023
@xialeistudio xialeistudio changed the title bugfix: fix time format in **de-DE** bugfix: fix time format in de-DE Nov 14, 2023
@xialeistudio
Copy link
Contributor Author

Fixed this issue #391

Hi, if you just want to fix the timing problem mentioned in this issu, you can close the isu first, re-initiate the PR, and modify the title and commit information of the response, so that your PR is a complete function and we can merge it. Looking forward to your contribution.

OK, I have modified the title and commit information

@xialeistudio xialeistudio deleted the xialeistudio-bugfix/391 branch November 14, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuashuai shuashuai shuashuai requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xialeistudio @shuashuai