Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/1.2.0/userprofile (#661) #672

Closed

Conversation

insistedMarin
Copy link

This Pull Request introduces a new filtering functionality to the userprofile page. The main objective of this update is to enhance the user experience by providing a more refined control over the visibility of posts.

Key Changes:

  1. Filter Implementation for topData and listData: The topData and listData on the userprofile page have been updated with a filtering mechanism. This feature filters out 'unlisted' posts, ensuring that they are only visible to specific user roles.

  2. Role-Based Visibility: The visibility of 'unlisted' posts is now restricted. These posts are only displayed to the Post author, Admin, and Moderator roles.

Testing:
The new filter functionality has been thoroughly tested to ensure it operates as intended across various scenarios. Tests included checking the visibility of posts for different user roles and verifying the correct functioning of the topData and listData filters.

Looking forward to your feedback and suggestions on this implementation.

Thank you for considering this Pull Request.

Related issue: #661

@shuashuai shuashuai self-assigned this Dec 11, 2023
@shuashuai shuashuai self-requested a review December 11, 2023 03:10
@shuashuai
Copy link
Member

First of all thank you for your contribution!

A good solution should be to adjust the results returned by the corresponding API through token authentication! Calling the details API in batches through the list is not a good solution!

As developers, we should think more about whether the solution is reasonable! This is a very important concept!

@insistedMarin
Copy link
Author

Thank you very much for your guidance, I will revisit this issue !

@shuashuai
Copy link
Member

Thank you very much for your guidance, I will revisit this issue !

This requires adjusting some logic on the backend. If you need technical support, you can contact @LinkinStars for help.

@hgaol
Copy link
Member

hgaol commented Dec 12, 2023

if needed, I can help with the backend part. :)

@insistedMarin
Copy link
Author

if needed, I can help with the backend part. :)

Many thanks if you can provide any help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants