fix: use PATCH instead of PUT

apache · Dec 9, 2020 · 9b7152d · 9b7152d
1 parent 935dd7f
commit 9b7152d
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 16 deletions.
diff --git a/web/src/pages/Route/List.tsx b/web/src/pages/Route/List.tsx
@@ -36,6 +36,17 @@ const Page: React.FC = () => {
     ref.current?.reload();
   };
 
+  const handlePublishOffline = (rid: string, status: RouteModule.RouteStatus) => {
+    updateRouteStatus(rid, status).then(() => {
+      const actionName = status? formatMessage({ id: 'page.route.publish' }) : formatMessage({ id: 'page.route.offline' })
+      handleTableActionSuccessResponse(
+        `${actionName}${formatMessage({
+          id: 'menu.routes',
+        })}${formatMessage({ id: 'component.status.success' })}`,
+      );
+    });
+  }
+
   const columns: ProColumns<RouteModule.ResponseBody>[] = [
     {
       title: formatMessage({ id: 'component.global.name' }),
@@ -107,13 +118,7 @@ const Page: React.FC = () => {
             <Button
               type="primary"
               onClick={() => {
-                updateRouteStatus(record.id, 'publish').then(() => {
-                  handleTableActionSuccessResponse(
-                    `${formatMessage({ id: 'page.route.publish' })}${formatMessage({
-                      id: 'menu.routes',
-                    })}${formatMessage({ id: 'component.status.success' })}`,
-                  );
-                });
+                handlePublishOffline(record.id, 1)
               }}
               style={{ marginRight: 10 }}
               disabled={Boolean(record.status)}
@@ -123,16 +128,11 @@ const Page: React.FC = () => {
             <Popconfirm
               title={formatMessage({ id: 'page.route.popconfirm.title.offline' })}
               onConfirm={() => {
-                updateRouteStatus(record.id!, 'offline').then(() => {
-                  handleTableActionSuccessResponse(
-                    `${formatMessage({ id: 'page.route.offline' })}${formatMessage({
-                      id: 'menu.routes',
-                    })}${formatMessage({ id: 'component.status.success' })}`,
-                  );
-                });
+                handlePublishOffline(record.id, 0)
               }}
               okText={formatMessage({ id: 'component.global.confirm' })}
               cancelText={formatMessage({ id: 'component.global.cancel' })}
+              disabled={Boolean(!record.status)}
             >
               <Button type="primary" danger disabled={Boolean(!record.status)}>
                 {formatMessage({ id: 'page.route.offline' })}

diff --git a/web/src/pages/Route/service.ts b/web/src/pages/Route/service.ts
@@ -87,4 +87,7 @@ export const checkHostWithSSL = (hosts: string[]) =>
   });
 
 export const updateRouteStatus = (rid: string, status: RouteModule.RouteStatus) =>
-  request(`/routes/${rid}/${status}`, { method: 'PUT' });
+  request(`/routes/${rid}`, {
+    method: 'PATCH',
+    data: {status}
+  });
diff --git a/web/src/pages/Route/typing.d.ts b/web/src/pages/Route/typing.d.ts
@@ -273,5 +273,5 @@ declare namespace RouteModule {
     status: number;
   };
 
-  type RouteStatus = 'publish' | 'offline';
+  type RouteStatus = 0 | 1;
 }