Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: some apis bypassed authentication #1351

Closed
nic-chen opened this issue Jan 22, 2021 · 2 comments · Fixed by #1373
Closed

bug: some apis bypassed authentication #1351

nic-chen opened this issue Jan 22, 2021 · 2 comments · Fixed by #1373
Assignees
@nic-chen
Labels
backend bug Something isn't working
Milestone
2.4

Comments

@nic-chen
Copy link
Member

Bug report

Describe the bug

I found that some apis that need to get the original data of the request without using the droplet bypass the authentication, I think it's due to #1296

we need to fix it before release.

System information

  • OS: [e.g. macOS, Windows] macOS
  • Browser (if applies) [e.g. Chrome, Safari, Edge]
  • Version: [e.g. 2.0-rc3] master
@nic-chen nic-chen added the bug Something isn't working label Jan 22, 2021
@nic-chen nic-chen added this to the 2.4 milestone Jan 22, 2021
@nic-chen
Copy link
Member Author

cc @starsz

@starsz
Copy link
Contributor

starsz commented Jan 22, 2021

Right. It's a bug.
IMO, we can wrap those functions into droplet, because the droplet has updated before.

@nic-chen nic-chen self-assigned this Jan 25, 2021
@nic-chen nic-chen mentioned this issue Jan 25, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nic-chen nic-chen

Labels
backend bug Something isn't working
Projects
None yet
Milestone
2.4
Development

Successfully merging a pull request may close this issue.

fix: some apis bypassed authentication nic-chen/incubator-apisix-dashboard
2 participants
@starsz @nic-chen