-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: some apis bypassed authentication #1373
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1373 +/- ##
==========================================
+ Coverage 62.29% 65.30% +3.00%
==========================================
Files 42 42
Lines 2395 2392 -3
==========================================
+ Hits 1492 1562 +70
+ Misses 722 646 -76
- Partials 181 184 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good to me, except some tiny modifications. Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Will merge this once CI passes. Thanks @nic-chen .
Please answer these questions before submitting a pull request
Why submit this pull request?
Bugfix
New feature provided
Improve performance
Backport patches
Related issues
close bug: some apis bypassed authentication #1351
Bugfix
I found that some apis that need to get the original data of the request without using the droplet bypass the authentication, I think it's due to #1296
upgrade
droplet
framework, and update the apis that not usingdroplet
to usedroplet