Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: some apis bypassed authentication #1373

Merged
merged 11 commits into from
Jan 27, 2021
Merged

Conversation

nic-chen
Copy link
Member

Please answer these questions before submitting a pull request


Bugfix

  • Description

I found that some apis that need to get the original data of the request without using the droplet bypass the authentication, I think it's due to #1296

  • How to fix?

upgrade droplet framework, and update the apis that not using droplet to use droplet

@codecov-io
Copy link

codecov-io commented Jan 25, 2021

Codecov Report

Merging #1373 (ada026a) into master (1bdcaa8) will increase coverage by 3.00%.
The diff coverage is 94.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1373      +/-   ##
==========================================
+ Coverage   62.29%   65.30%   +3.00%     
==========================================
  Files          42       42              
  Lines        2395     2392       -3     
==========================================
+ Hits         1492     1562      +70     
+ Misses        722      646      -76     
- Partials      181      184       +3     
Impacted Files Coverage Δ
api/internal/utils/consts/api_error.go 50.00% <ø> (-45.66%) ⬇️
api/internal/handler/ssl/ssl.go 48.14% <80.00%> (+0.86%) ⬆️
api/internal/handler/global_rule/global_rule.go 83.87% <100.00%> (+0.82%) ⬆️
api/internal/handler/route/route.go 77.44% <100.00%> (+10.05%) ⬆️
api/internal/handler/upstream/upstream.go 70.16% <100.00%> (+28.83%) ⬆️
api/internal/core/store/storehub.go 70.40% <0.00%> (-4.09%) ⬇️
api/internal/core/storage/etcd.go 50.50% <0.00%> (ø)
api/internal/core/store/query.go 97.61% <0.00%> (+9.52%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bdcaa8...ada026a. Read the comment docs.

Copy link
Member

@imjoey imjoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me, except some tiny modifications. Thank you.

api/go.sum Show resolved Hide resolved
api/test/docker/Dockerfile Show resolved Hide resolved
Copy link
Member

@imjoey imjoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Will merge this once CI passes. Thanks @nic-chen .

@nic-chen nic-chen merged commit fa080a8 into apache:master Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: some apis bypassed authentication
8 participants