Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation error #1596

Closed
stu01509 opened this issue Mar 15, 2021 · 7 comments · Fixed by #1605
Closed

Translation error #1596

stu01509 opened this issue Mar 15, 2021 · 7 comments · Fixed by #1605
Assignees
Labels
bug Something isn't working

Comments

@stu01509
Copy link
Contributor

Bug report

Describe the bug

Hi all
I found when I switch the language to the English on some page and element still used the Chinese

How to Reproduce

  1. Go to Route List
  2. See the error

Expected behavior

A clear and concise description of what you expected to happen.

Screenshots

  • Route List
    image
    image

Add screenshots to help explain your problem if applicable.

System information

  • OS: [e.g. macOS, Windows]
  • Browser (if applies) [e.g. Chrome, Safari, Edge]
  • Version: [e.g. 2.0-rc3]

Additional context

If it is a bug, I would like to solve it.

@stu01509 stu01509 added the bug Something isn't working label Mar 15, 2021
@nic-chen
Copy link
Member

great, we could check other place, and fix them all.

@juzhiyuan
Copy link
Member

Hi @stu01509, we just merged a PR #1538

This PR fixes most of the translation issues, @guoqqqi Please recheck if those issues exist.

@imjoey
Copy link
Member

imjoey commented Mar 16, 2021

@stu01509 thanks for reporting and assign this to you. Let's wait for the confirmation from @guoqqqi .

@guoqqqi
Copy link
Member

guoqqqi commented Mar 16, 2021

Hi, @stu01509 This issue has been fixed and you can see it by updating the master branch code, (which requires deleting the local cache, node_modules and .umi).
image

@stu01509
Copy link
Contributor Author

Hi @nic-chen, @juzhiyuan, @imjoey, and @qiujiayu

After I recheck, Almost the translation error has been solved, but I still found in the System Status uptime field mixed some Chinese.
image

@guoqqqi
Copy link
Member

guoqqqi commented Mar 16, 2021

Yes, there are still some problems here. @stu01509 Can you help fix it?

@stu01509
Copy link
Contributor Author

Yes, there are still some problems here. @stu01509 Can you help fix it?

Sure 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants