fix: fix the uptime translation error #1605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @guoqqqi to guide how to fix this test |
|
OK, Let me check it. |
guoqqqi
added a commit
to guoqqqi/apisix-dashboard
that referenced
this pull request
Mar 17, 2021
|
Hi, When you have time, please update the master code to fix the error. |
|
Hi @guoqqqi Update the commit |
Codecov Report
@@ Coverage Diff @@
## master #1605 +/- ##
==========================================
+ Coverage 71.69% 71.76% +0.07%
==========================================
Files 133 133
Lines 5469 5469
Branches 592 592
==========================================
+ Hits 3921 3925 +4
+ Misses 1305 1300 -5
- Partials 243 244 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Hi @juzhiyuan and @guoqqqi Seems like this PR passed the CI, Please review it 😀 |
juzhiyuan
approved these changes
Mar 20, 2021
liuxiran
approved these changes
Mar 21, 2021
guoqqqi
approved these changes
Mar 21, 2021
Jaycean
approved these changes
Mar 21, 2021
nic-chen
approved these changes
Mar 23, 2021
|
@stu01509 Hi, please sync latest codes. |
…six-dashboard into fix-#1596-translation-error
Done 😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting a pull request
Why submit this pull request?
Bugfix
New feature provided
Improve performance
Backport patches
Related issues
Fix Translation error #1596
Bugfix
Fix the uptime translation error in English mode.
Add moment locale.
English Mode:
Chinese Mode:
