Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unstable front-end tests #1608

Merged
merged 3 commits into from
Mar 18, 2021
Merged

fix: unstable front-end tests #1608

merged 3 commits into from
Mar 18, 2021

Conversation

guoqqqi
Copy link
Member

@guoqqqi guoqqqi commented Mar 17, 2021

Please answer these questions before submitting a pull request

Why submit this pull request?

  • Bugfix

Related issues
related #1605


fixed unstable front-end tests.

@guoqqqi guoqqqi marked this pull request as draft March 17, 2021 15:56
@guoqqqi guoqqqi marked this pull request as ready for review March 17, 2021 16:53
@juzhiyuan juzhiyuan requested a review from LiteSun March 17, 2021 16:59
@guoqqqi guoqqqi closed this Mar 17, 2021
@guoqqqi guoqqqi reopened this Mar 17, 2021
@codecov-io
Copy link

codecov-io commented Mar 17, 2021

Codecov Report

Merging #1608 (7872246) into master (4b8774f) will increase coverage by 1.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1608      +/-   ##
==========================================
+ Coverage   71.37%   72.49%   +1.11%     
==========================================
  Files         133       86      -47     
  Lines        5384     2356    -3028     
  Branches      592      592              
==========================================
- Hits         3843     1708    -2135     
+ Misses       1297      648     -649     
+ Partials      244        0     -244     
Flag Coverage Δ
backend-e2e-test ?
backend-e2e-test-ginkgo ?
backend-unit-test ?
frontend-e2e-test 72.49% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/helpers.tsx 77.04% <0.00%> (-3.28%) ⬇️
api/internal/handler/service/service.go
api/internal/handler/schema/schema.go
api/cmd/manager/main.go
api/internal/conf/conf.go
api/internal/utils/closer.go
api/internal/filter/request_id.go
api/internal/core/store/store.go
api/internal/log/zap.go
api/internal/handler/schema/plugin.go
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b8774f...7872246. Read the comment docs.

@LiteSun LiteSun requested review from liuxiran and bzp2010 March 18, 2021 08:20
Copy link
Member

@juzhiyuan juzhiyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guoqqqi guoqqqi mentioned this pull request Mar 18, 2021
4 tasks
@juzhiyuan juzhiyuan requested review from Jaycean and imjoey March 18, 2021 14:40
Copy link
Member

@Jaycean Jaycean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jaycean Jaycean merged commit 735a082 into apache:master Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants