Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: i18n #331

Closed
juzhiyuan opened this issue Jul 23, 2020 · 3 comments
Closed

Proposal: i18n #331

juzhiyuan opened this issue Jul 23, 2020 · 3 comments
Labels

Comments

@juzhiyuan
Copy link
Member

juzhiyuan commented Jul 23, 2020

@TikWind We need a proposal to make our i18n cleaner and reasonable.

@juzhiyuan
Copy link
Member Author

  1. Please take a look at how WordPress does;
  2. We need a good design on how the sub key is grouped to a key;

@juzhiyuan juzhiyuan pinned this issue Jul 23, 2020
@liuxiran
Copy link
Contributor

liuxiran commented Aug 6, 2020

Hi, I have a proposal the key can be like this : [basicModule].[moduleName].[elementName].[...desc]

  1. basic keys (the first tow levels) divide according to the directory structure:
    eg: app.pwa, page.consumer, component.actionBar

  2. sub keys divide according to element +description
    eg: app.pwa.message.offline, component.actionBar.button.nextStep
    If the the text is the part of a element, we can use [elementName.props]
    eg: page.consumer.proTable.columns.username

  3. common texts, we should not repeat in other part, we can divide them to component.global.xxx
    eg: component.global.button.okText, component.global.status.loading and so on

@juzhiyuan
Copy link
Member Author

Agree +1

@juzhiyuan juzhiyuan unpinned this issue Aug 13, 2020
liuxiran added a commit to liuxiran/apisix-dashboard that referenced this issue Aug 13, 2020
liuxiran added a commit to liuxiran/apisix-dashboard that referenced this issue Aug 13, 2020
liuxiran added a commit to liuxiran/apisix-dashboard that referenced this issue Aug 13, 2020
liuxiran added a commit to liuxiran/apisix-dashboard that referenced this issue Aug 13, 2020
liuxiran added a commit to liuxiran/apisix-dashboard that referenced this issue Aug 13, 2020
@liuxiran liuxiran mentioned this issue Sep 23, 2020
13 tasks
liuxiran added a commit to liuxiran/apisix-dashboard that referenced this issue Sep 27, 2020
liuxiran added a commit to liuxiran/apisix-dashboard that referenced this issue Sep 27, 2020
liuxiran added a commit to liuxiran/apisix-dashboard that referenced this issue Sep 27, 2020
liuxiran added a commit to liuxiran/apisix-dashboard that referenced this issue Sep 27, 2020
liuxiran added a commit to liuxiran/apisix-dashboard that referenced this issue Sep 27, 2020
liuxiran added a commit to liuxiran/apisix-dashboard that referenced this issue Sep 27, 2020
liuxiran added a commit to liuxiran/apisix-dashboard that referenced this issue Sep 27, 2020
liuxiran added a commit to liuxiran/apisix-dashboard that referenced this issue Sep 27, 2020
liuxiran added a commit to liuxiran/apisix-dashboard that referenced this issue Sep 27, 2020
liuxiran added a commit to liuxiran/apisix-dashboard that referenced this issue Sep 27, 2020
@liuxiran liuxiran mentioned this issue Sep 27, 2020
3 tasks
juzhiyuan pushed a commit that referenced this issue Sep 28, 2020
* fix(i18n): modify pluginPage i18n refer to Proposal (#331)

* fix(i18n): modify global i18n refer to Proposal (#331)

* fix(i18n): modify consumer page i18n refer to Proposal (#331)

* fix(i18n): modify pluginPage i18n refer to Proposal (#331)

* fix(i18n): modify page route i18n refer to Proposal (#331)

* fix(i18n): update route i18n

* fix(i18n): modify page routegroup i18n refer to Proposal

* fix(i18n): modify page ssl i18n refer to Proposal

* fix: update refer to the lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants