Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Refactor Route publish and offline #837

Closed
1 task done
liuxiran opened this issue Nov 20, 2020 · 9 comments
Closed
1 task done

feat: Refactor Route publish and offline #837

liuxiran opened this issue Nov 20, 2020 · 9 comments
Assignees
Labels
Milestone

Comments

@liuxiran
Copy link
Contributor

liuxiran commented Nov 20, 2020

Please answer these questions before submitting your issue.

  • Why do you submit this issue?
  • Feature or performance improvement

Refer to:
#611
#437

Refactor:

  • APISIX implement Route publish/offline status in dp (issue: Proposal: Support enable/disable route apisix#2737)

  • manager-api provides an interface to write data to etcd

  • fe add publish and offline button to every route item list table, at the same time, create route also need to add a publish form item.

@juzhiyuan
Copy link
Member

cc @nic-chen

@nic-chen
Copy link
Member

LGTM

@juzhiyuan
Copy link
Member

Then do we have a final plan? dev, due date, and so on.

@LiteSun LiteSun added this to the 2.2 milestone Nov 23, 2020
@LiteSun
Copy link
Member

LiteSun commented Nov 23, 2020

I think this issue should be kept in sync with the apisix (issue: apache/apisix#2737) milestone.

@moonming
Copy link
Member

moonming commented Dec 7, 2020

This PR is in 2.2 milestone, and Apache APISIX supports it in apache/apisix#2943

@moonming
Copy link
Member

moonming commented Dec 7, 2020

What is the progress in dashboard? @liuxiran @nic-chen

@membphis
Copy link
Member

membphis commented Dec 7, 2020

this feature depends on apache/apisix#2943

we need to release a new version of APISIX. so I want to change the milestone to 2.3

@liuxiran @nic-chen please confirm if this is ok ^_^

@liuxiran
Copy link
Contributor Author

liuxiran commented Dec 7, 2020

this feature depends on apache/apisix#2943

we need to release a new version of APISIX. so I want to change the milestone to 2.3

@liuxiran @nic-chen please confirm if this is ok ^_^

ok, and related pr for fe and manager-api will be created as a draft later this week.

@membphis membphis modified the milestones: 2.2, 2.3 Dec 7, 2020
@LiteSun
Copy link
Member

LiteSun commented Dec 11, 2020

Just for reminder: apache/apisix#2943 is merged. cc @liuxiran

@nic-chen nic-chen changed the title [Proposal]: Refactor Route publish and offline feat: Refactor Route publish and offline Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants