-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support patch in route module in order to support publish/offline #1049
Conversation
2768523
to
8ce330b
Compare
Codecov Report
@@ Coverage Diff @@
## master #1049 +/- ##
==========================================
- Coverage 40.13% 39.66% -0.48%
==========================================
Files 26 26
Lines 1572 1591 +19
==========================================
Hits 631 631
- Misses 850 869 +19
Partials 91 91
Continue to review full report at Codecov.
|
api/test/e2e/route_test.go
Outdated
func TestRoute_Patch(t *testing.T) { | ||
tests := []HttpTestCase{ | ||
{ | ||
caseDesc: "route patch", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should always create the related resource first.
eg: the route
resource
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
It seems that the E2E test cases is unstable, @nic-chen please take a look:
|
en, I have been working on it. |
CI failed @liuxiran |
80692e0
to
13ae49a
Compare
Thanks for @nic-chen 's help, all test cases passed |
How about using the codes from apisix's master branch? |
sure,we don't need to wait now. |
this pr has beening splited into two prs, and will be closed after all the separated prs merged |
this PR should be closed now. feel free to reopen it if you need. |
Please answer these questions before submitting a pull request
Why submit this pull request?
New feature provided
Related issues
BE of #837
support for #991
borrow from #1005
depends on APISIX release with apache/apisix#2737 and sync
https://github.com/apache/apisix-dashboard/blob/master/api/conf/schema.json