fix: Remove update_time and create_time from ServerInfo entity

[imjoey]

Please answer these questions before submitting a pull request

• Why submit this pull request?

• Bugfix

• New feature provided

• Improve performance

• Related issues

Fixes #1176 .

---

Bugfix

• Description

The empty values of create_time and update_time should not be returned from server_info interface provided by manager-api . Please see #1176 for details.

• How to fix?

This PR is going to set create_time and update_time as omitempty to disable JSON serialization when returning back to frontend. In addition, adding the relevant test case for changes.

[codecov-io]

Codecov Report

Merging #1192 (b353041) into master (62d1c43) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1192      +/-   ##
==========================================
- Coverage   42.38%   42.33%   -0.06%     
==========================================
  Files          31       31              
  Lines        1930     1930              
==========================================
- Hits          818      817       -1     
- Misses       1001     1002       +1     
  Partials      111      111              

Impacted Files	Coverage Δ
api/internal/core/entity/entity.go	0.00% <ø> (ø)
api/internal/core/store/store.go	79.37% <0.00%> (-0.63%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62d1c43...b353041. Read the comment docs.

[imjoey]

To make it more clear, I just added a new field UnexpectedBody here, which reformatted the alignment.

[liuxiran]

I noticed that each field in the BaseInfo struct is not omited originly, but in this pr, we set create_time and update_time omitempty, so is it posible to set create_time and update_time out of BaseInfo struct?

@imjoey @nic-chen @starsz

[nic-chen]

I noticed that each field in the BaseInfo struct is not omited originly, but in this pr, we set create_time and update_time omitempty, so is it posible to set create_time and update_time out of BaseInfo struct?

@imjoey @nic-chen @starsz

Yes, a better solution is to separate create_time, update_time and ID.

In the next version, we will remove the consumer ID:
apache/apisix#2679

It will need create_time and update_time but no ID.

[imjoey]

@liuxiran @nic-chen Thanks for your advice. While unfortunately, for now ServerInfo still relies on the BaseInfo object for sorting in List interface. Since #1176 is not a critical bug, thus there seems no perfect solution right now, I prefer to close this PR and would reopen it once we work out an overall refactor design that fits for all entities.