chore: add stop subcommand #1333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tokers , thank you for this. Just FYI, the file |
nic-chen
reviewed
Jan 19, 2021
yes, we should not submit the binary |
Oh my gosh, i'll remove it, sorry~ |
Codecov Report
@@ Coverage Diff @@
## master #1333 +/- ##
==========================================
- Coverage 44.31% 44.02% -0.29%
==========================================
Files 32 33 +1
Lines 1961 1976 +15
==========================================
+ Hits 869 870 +1
- Misses 981 995 +14
Partials 111 111
Continue to review full report at Codecov.
|
starsz
requested changes
Jan 20, 2021
|
You should add instructions in the document. |
membphis
reviewed
Jan 20, 2021
|
ping @tokers |
|
Ok, will add it as soon as Possible. |
nic-chen
approved these changes
Jan 22, 2021
|
ping @tokers |
imjoey
approved these changes
Jan 25, 2021
starsz
approved these changes
Jan 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting a pull request
Why submit this pull request?
Bugfix
New feature provided
Improve performance
Backport patches
Related issues
close #741
Bugfix
Description
How to fix?
New feature or improvement
Please add the corresponding test cases if necessary.
Backport patches
Why need to backport?
Source branch
Related commits and pull requests
Target branch