-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(fe): support file transfer in online debug #1466
Conversation
|
Codecov Report
@@ Coverage Diff @@
## master #1466 +/- ##
===========================================
- Coverage 68.61% 55.49% -13.13%
===========================================
Files 48 48
Lines 3056 3056
===========================================
- Hits 2097 1696 -401
- Misses 718 1077 +359
- Partials 241 283 +42
Continue to review full report at Codecov.
|
everything is ready now, please take a look when you are free, thanks |
OK |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Except for the typos.
https://github.com/apache/apisix-dashboard/pull/1466/checks?check_run_id=1984404224 |
OK, let me check the E2E test case |
Conflicting files, please merge the master branch |
thanks all reviewers and @juzhiyuan' s help , pr merged. |
Please answer these questions before submitting a pull request
Why submit this pull request?
Bugfix
New feature provided
Improve performance
Backport patches
Related issues
FE of support debug file transfer in online debug #1217
related Be pr: feat(be): Online debug function adds support for transfer files #1465
New feature or improvement
suport
Content-type: multipart/form-data
in request expectGET
andHEAD
Please add the corresponding test cases if necessary.
TODO: