Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fe): support file transfer in online debug #1466

Merged
merged 10 commits into from
Mar 2, 2021

Conversation

liuxiran
Copy link
Contributor

@liuxiran liuxiran commented Feb 9, 2021

Please answer these questions before submitting a pull request


New feature or improvement

  • Describe the details and related test reports.

suport Content-type: multipart/form-data in request expect GET and HEAD

mmexport1612875222163


Please add the corresponding test cases if necessary.

TODO:

  • add e2e test cases

@liuxiran liuxiran marked this pull request as draft February 9, 2021 13:00
@juzhiyuan
Copy link
Member

juzhiyuan commented Feb 18, 2021

Hi, please sync your codes with the master branch to fix the CI failure.

@codecov-io
Copy link

codecov-io commented Feb 20, 2021

Codecov Report

Merging #1466 (d3f6eba) into master (e51323f) will decrease coverage by 13.12%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1466       +/-   ##
===========================================
- Coverage   68.61%   55.49%   -13.13%     
===========================================
  Files          48       48               
  Lines        3056     3056               
===========================================
- Hits         2097     1696      -401     
- Misses        718     1077      +359     
- Partials      241      283       +42     
Impacted Files Coverage Δ
api/internal/core/store/query.go 0.00% <0.00%> (-88.10%) ⬇️
api/internal/core/store/selector.go 0.00% <0.00%> (-75.93%) ⬇️
api/internal/handler/plugin/plugin.go 15.15% <0.00%> (-72.73%) ⬇️
api/internal/utils/runtime/runtime.go 0.00% <0.00%> (-64.29%) ⬇️
api/internal/core/store/validate_mock.go 0.00% <0.00%> (-50.00%) ⬇️
api/internal/handler/service/service.go 54.25% <0.00%> (-37.24%) ⬇️
api/internal/handler/ssl/ssl.go 34.69% <0.00%> (-34.19%) ⬇️
api/internal/filter/authentication.go 41.66% <0.00%> (-30.56%) ⬇️
api/internal/core/store/store.go 60.24% <0.00%> (-26.51%) ⬇️
api/internal/filter/ip_filter.go 48.71% <0.00%> (-23.08%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e51323f...d3f6eba. Read the comment docs.

@liuxiran liuxiran marked this pull request as ready for review February 20, 2021 17:58
@juzhiyuan juzhiyuan requested review from LiteSun and bzp2010 February 20, 2021 21:17
@liuxiran liuxiran requested a review from juzhiyuan February 25, 2021 22:54
@liuxiran
Copy link
Contributor Author

everything is ready now, please take a look when you are free, thanks

@juzhiyuan @LiteSun @bzp2010

@juzhiyuan
Copy link
Member

OK

Copy link
Member

@LiteSun LiteSun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Except for the typos.

web/cypress/integration/route/online-debug.spec.js Outdated Show resolved Hide resolved
@liuxiran
Copy link
Contributor Author

@Jaycean
Copy link
Member

Jaycean commented Feb 26, 2021

https://github.com/apache/apisix-dashboard/pull/1466/checks?check_run_id=1984404224
Backend e2e failed, need @Jaycean to confirm.

OK, let me check the E2E test case

@membphis
Copy link
Member

membphis commented Mar 1, 2021

Conflicting files, please merge the master branch

@liuxiran
Copy link
Contributor Author

liuxiran commented Mar 2, 2021

thanks all reviewers and @juzhiyuan' s help , pr merged.

@liuxiran liuxiran merged commit fd271e9 into apache:master Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants