Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Remove wait Reduce test time #1469

Merged
merged 15 commits into from
Feb 22, 2021
Merged

test: Remove wait Reduce test time #1469

merged 15 commits into from
Feb 22, 2021

Conversation

guoqqqi
Copy link
Member

@guoqqqi guoqqqi commented Feb 10, 2021

Please answer these questions before submitting a pull request


Reduce the test time of schema-smocktest by removing the wait from the global functions

@guoqqqi guoqqqi closed this Feb 10, 2021
@guoqqqi guoqqqi reopened this Feb 10, 2021
@codecov-io
Copy link

codecov-io commented Feb 10, 2021

Codecov Report

Merging #1469 (9744ac7) into master (bd5ed03) will decrease coverage by 0.26%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1469      +/-   ##
==========================================
- Coverage   68.95%   68.69%   -0.27%     
==========================================
  Files          48       48              
  Lines        3038     3038              
==========================================
- Hits         2095     2087       -8     
- Misses        705      712       +7     
- Partials      238      239       +1     
Impacted Files Coverage Δ
api/internal/core/store/storehub.go 70.40% <0.00%> (-4.09%) ⬇️
api/internal/core/storage/etcd.go 47.27% <0.00%> (-3.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd5ed03...9744ac7. Read the comment docs.

@juzhiyuan
Copy link
Member

#1470

@juzhiyuan
Copy link
Member

Hi, please sync your codes with the master branch to fix the CI failure.

@liuxiran
Copy link
Contributor

2021-02-18 13-06-59屏幕截图

I tried this pr branch locally, and found that sometimes the delete test case ran failed, which happened due to four plugins involved in case were not successfully enabled, so there is not any plugins in the plugin list.
It is likely to increase the instability of this test case, If you can reproduce this error locally(maybe you need to try more times), we'd better tried other way to reduce test time in this test case ^_^ @guoqqqi

@guoqqqi
Copy link
Member Author

guoqqqi commented Feb 18, 2021

OK, let me check

@guoqqqi
Copy link
Member Author

guoqqqi commented Feb 20, 2021

Hi, I saw that the two tests in the plugin had something in common, so I combined the two tests into one test and successfully removed the wait()

Copy link
Member

@membphis membphis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juzhiyuan
Copy link
Member

Hi @qier222 , you could have a try to review this PR :)

@juzhiyuan juzhiyuan merged commit 8667c28 into apache:master Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reduce plugin testcases' running time
5 participants