-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Remove wait Reduce test time #1469
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1469 +/- ##
==========================================
- Coverage 68.95% 68.69% -0.27%
==========================================
Files 48 48
Lines 3038 3038
==========================================
- Hits 2095 2087 -8
- Misses 705 712 +7
- Partials 238 239 +1
Continue to review full report at Codecov.
|
Hi, please sync your codes with the master branch to fix the CI failure. |
I tried this pr branch locally, and found that sometimes the delete test case ran failed, which happened due to four plugins involved in case were not successfully enabled, so there is not any plugins in the plugin list. |
OK, let me check |
Hi, I saw that the two tests in the plugin had something in common, so I combined the two tests into one test and successfully removed the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi @qier222 , you could have a try to review this PR :) |
Please answer these questions before submitting a pull request
Why submit this pull request?
Bugfix
New feature provided
Improve performance
Backport patches
Related issues
resolve reduce plugin testcases' running time #1371
Reduce the test time of
schema-smocktest
by removing thewait
from the global functions