-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support yaml to config plugin in plugin config page #1490
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1490 +/- ##
===========================================
- Coverage 70.86% 51.68% -19.19%
===========================================
Files 135 40 -95
Lines 5485 2707 -2778
Branches 583 0 -583
===========================================
- Hits 3887 1399 -2488
+ Misses 1350 1127 -223
+ Partials 248 181 -67
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
web/src/helpers.tsx
Outdated
* @param jsonStr | ||
*/ | ||
export const json2yaml = (jsonStr: string): string => { | ||
return yaml.dump(JSON.parse(jsonStr)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if jsonStr's value is ''
, an error will occur
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks a lot, already fixed.
use try...catch
to handle the exception
Front-end e2e test required. |
got it, I`ll add it soon, thanks |
I have no idea how to resolve this conflict 😂 please fix it when you have time. |
ping @LiteSun |
Please answer these questions before submitting a pull request
Why submit this pull request?
Bugfix
New feature provided
Improve performance
Backport patches
Related issues
Part of Build plugin form according to its jsonschema #1039
New feature or improvement
1
2
Notice: all above are just transforms in FE, it would not disturb the interface data transfer
Please add the corresponding test cases if necessary.