Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support yaml to config plugin in plugin config page #1490

Merged
merged 10 commits into from
Mar 15, 2021

Conversation

liuxiran
Copy link
Contributor

Please answer these questions before submitting a pull request


New feature or improvement

  • Describe the details and related test reports.

1
image

2
image

Notice: all above are just transforms in FE, it would not disturb the interface data transfer


Please add the corresponding test cases if necessary.

@codecov-io
Copy link

codecov-io commented Feb 20, 2021

Codecov Report

Merging #1490 (7d7af37) into master (938b2b9) will decrease coverage by 19.18%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1490       +/-   ##
===========================================
- Coverage   70.86%   51.68%   -19.19%     
===========================================
  Files         135       40       -95     
  Lines        5485     2707     -2778     
  Branches      583        0      -583     
===========================================
- Hits         3887     1399     -2488     
+ Misses       1350     1127      -223     
+ Partials      248      181       -67     
Flag Coverage Δ
backend-e2e-test ?
backend-e2e-test-ginkgo ?
backend-unit-test 51.68% <ø> (ø)
frontend-e2e-test ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/internal/utils/version.go 0.00% <0.00%> (-100.00%) ⬇️
api/internal/filter/request_id.go 0.00% <0.00%> (-100.00%) ⬇️
api/internal/core/entity/entity.go 0.00% <0.00%> (-100.00%) ⬇️
api/internal/core/store/storehub.go 0.00% <0.00%> (-71.03%) ⬇️
api/internal/filter/cors.go 0.00% <0.00%> (-66.67%) ⬇️
api/internal/filter/schema.go 0.00% <0.00%> (-55.47%) ⬇️
api/internal/utils/consts/api_error.go 0.00% <0.00%> (-50.00%) ⬇️
api/internal/handler/data_loader/route_import.go 27.41% <0.00%> (-37.50%) ⬇️
api/internal/handler/server_info/server_info.go 57.14% <0.00%> (-33.34%) ⬇️
api/internal/utils/closer.go 0.00% <0.00%> (-33.34%) ⬇️
... and 114 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 938b2b9...7d7af37. Read the comment docs.

@juzhiyuan juzhiyuan requested a review from LiteSun February 20, 2021 23:30
@juzhiyuan juzhiyuan requested a review from bzp2010 February 22, 2021 22:12
@juzhiyuan juzhiyuan requested review from bzp2010 and LiteSun February 25, 2021 05:23
* @param jsonStr
*/
export const json2yaml = (jsonStr: string): string => {
return yaml.dump(JSON.parse(jsonStr))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if jsonStr's value is '', an error will occur

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot, already fixed.

use try...catch to handle the exception

@LiteSun
Copy link
Member

LiteSun commented Mar 4, 2021

Front-end e2e test required.

@liuxiran
Copy link
Contributor Author

liuxiran commented Mar 4, 2021

Front-end e2e test required.

got it, I`ll add it soon, thanks

@juzhiyuan
Copy link
Member

I have no idea how to resolve this conflict 😂 please fix it when you have time.

@juzhiyuan juzhiyuan requested a review from LiteSun March 7, 2021 00:26
@membphis
Copy link
Member

ping @LiteSun

@juzhiyuan juzhiyuan merged commit e22de29 into apache:master Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants