Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix fe ci failed #1577

Merged
merged 1 commit into from
Mar 12, 2021
Merged

fix: fix fe ci failed #1577

merged 1 commit into from
Mar 12, 2021

Conversation

Jaycean
Copy link
Member

@Jaycean Jaycean commented Mar 11, 2021

Please answer these questions before submitting a pull request

  • Why submit this pull request?

  • Bugfix

  • New feature provided

  • Improve performance

  • Backport patches

  • Related issues


Bugfix

fix FE ci failed
comment: #1570 (comment)

Fe ci repair should submit new PR and should not be mixed up.

@Jaycean Jaycean requested review from LiteSun and juzhiyuan March 11, 2021 17:01
@codecov-io
Copy link

codecov-io commented Mar 11, 2021

Codecov Report

Merging #1577 (4c39ccb) into master (611ab09) will decrease coverage by 9.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1577      +/-   ##
==========================================
- Coverage   70.02%   60.88%   -9.15%     
==========================================
  Files         132       46      -86     
  Lines        5341     3019    -2322     
  Branches      584        0     -584     
==========================================
- Hits         3740     1838    -1902     
+ Misses       1361      869     -492     
- Partials      240      312      +72     
Flag Coverage Δ
backend-e2e-test 60.88% <ø> (+10.89%) ⬆️
backend-e2e-test-ginkgo 44.48% <ø> (?)
backend-unit-test ?
frontend-e2e-test ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/internal/utils/runtime/runtime.go 0.00% <0.00%> (-64.29%) ⬇️
api/internal/core/store/validate_mock.go 0.00% <0.00%> (-50.00%) ⬇️
api/internal/handler/service/service.go 57.44% <0.00%> (-34.05%) ⬇️
api/internal/core/store/store.go 58.43% <0.00%> (-29.52%) ⬇️
api/internal/filter/authentication.go 47.22% <0.00%> (-25.00%) ⬇️
api/internal/filter/ip_filter.go 48.71% <0.00%> (-23.08%) ⬇️
api/internal/handler/global_rule/global_rule.go 64.51% <0.00%> (-19.36%) ⬇️
...pi/internal/handler/plugin_config/plugin_config.go 59.57% <0.00%> (-18.09%) ⬇️
api/internal/handler/route/route.go 63.59% <0.00%> (-14.65%) ⬇️
api/internal/utils/json_patch.go 44.82% <0.00%> (-13.80%) ⬇️
... and 105 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 611ab09...4c39ccb. Read the comment docs.

@juzhiyuan juzhiyuan merged commit afa05e7 into apache:master Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants