Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve Route module #1634

Merged
merged 6 commits into from
Mar 23, 2021
Merged

fix: improve Route module #1634

merged 6 commits into from
Mar 23, 2021

Conversation

qian0817
Copy link
Contributor

@qian0817 qian0817 commented Mar 20, 2021


New feature or improvement

image

  1. List page, search area field, supplement Placeholder.
  2. Create routing page, step 1, form should be aligned to the left, not centered.
  3. Create routing page, title remove spaces.
  4. Allow edge to use plugin orchestration.

1. List page, search area field, supplement Placeholder.
2. Create routing page, step 1, form should be aligned to the left, not centered.
3. Create routing page, title remove spaces.
@codecov-io
Copy link

codecov-io commented Mar 20, 2021

Codecov Report

Merging #1634 (7954c9c) into master (45df5b2) will decrease coverage by 9.95%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1634      +/-   ##
==========================================
- Coverage   71.92%   61.97%   -9.96%     
==========================================
  Files         133       47      -86     
  Lines        5472     3116    -2356     
  Branches      592        0     -592     
==========================================
- Hits         3936     1931    -2005     
+ Misses       1293      873     -420     
- Partials      243      312      +69     
Flag Coverage Δ
backend-e2e-test 61.97% <ø> (-0.29%) ⬇️
backend-e2e-test-ginkgo 47.97% <ø> (-0.29%) ⬇️
backend-unit-test ?
frontend-e2e-test ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/internal/utils/runtime/runtime.go 0.00% <0.00%> (-64.29%) ⬇️
api/internal/core/store/validate_mock.go 0.00% <0.00%> (-50.00%) ⬇️
api/internal/filter/authentication.go 47.22% <0.00%> (-30.56%) ⬇️
api/internal/handler/service/service.go 62.60% <0.00%> (-29.57%) ⬇️
api/internal/core/store/store.go 59.63% <0.00%> (-28.32%) ⬇️
api/internal/filter/ip_filter.go 48.71% <0.00%> (-23.08%) ⬇️
api/internal/handler/global_rule/global_rule.go 64.51% <0.00%> (-19.36%) ⬇️
...pi/internal/handler/plugin_config/plugin_config.go 59.57% <0.00%> (-18.09%) ⬇️
api/internal/utils/json_patch.go 44.82% <0.00%> (-13.80%) ⬇️
api/internal/handler/upstream/upstream.go 77.14% <0.00%> (-13.58%) ⬇️
... and 97 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45df5b2...7954c9c. Read the comment docs.

@juzhiyuan juzhiyuan requested a review from LiteSun March 20, 2021 15:11
@qian0817 qian0817 changed the title feat: improve Route module fix: improve Route module Mar 21, 2021
@juzhiyuan
Copy link
Member

also cc @guoqqqi to review

@guoqqqi guoqqqi mentioned this pull request Mar 22, 2021
4 tasks
qian0817 and others added 4 commits March 23, 2021 14:12
@juzhiyuan juzhiyuan merged commit 2ac7fb8 into apache:master Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants