Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rewrite e2e test route with plugin limit count test with ginkgo #1677

Conversation

Jaycean
Copy link
Member

@Jaycean Jaycean commented Mar 26, 2021

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

Related issues
#1500

rewrite e2e test route with plugin limit count test with ginkgo

@juzhiyuan
Copy link
Member

Hi, you could request proper reviewers :)

Copy link
Member

@nic-chen nic-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks.

@Jaycean Jaycean requested review from gxthrj, imjoey, starsz and tokers March 26, 2021 16:00
@Jaycean
Copy link
Member Author

Jaycean commented Mar 26, 2021

Hi, you could request proper reviewers :)

ok, Thks.

@starsz starsz merged commit 7adefe1 into apache:master Mar 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants